[webkit-changes] [WebKit/WebKit] 3b6d01: AX: Don't include password input value in aria-lab...

[Tommy McHugh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3b6d017ba868a66c08ca684570e44269fb2b1274
      https://github.com/WebKit/WebKit/commit/3b6d017ba868a66c08ca684570e44269fb2b1274
  Author: Tommy McHugh <thomas_mchugh at apple.com>
  Date:   2023-03-31 (Fri, 31 Mar 2023)

  Changed paths:
    M LayoutTests/accessibility-isolated-tree/TestExpectations
    A LayoutTests/accessibility/aria-labelledby-on-password-input-expected.txt
    A LayoutTests/accessibility/aria-labelledby-on-password-input.html
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp

  Log Message:
  -----------
  AX: Don't include password input value in aria-labelledby description
https://bugs.webkit.org/show_bug.cgi?id=248717
rdar://problem/102815043

Reviewed by Tyler Wilcock.

accessibleNameForNode is erroneously returning the raw password input value when
an element has an aria-labelledby attribute to an input element with a password type.
This patch fixes that by checking HTMLInputElement::isPasswordField before returning
the input's value and when there is a password field returning a masked value matching
the length of the true value.

* LayoutTests/accessibility-isolated-tree/TestExpectations:
* LayoutTests/accessibility/aria-labelledby-on-password-input-expected.txt: Added.
* LayoutTests/accessibility/aria-labelledby-on-password-input.html: Added.
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::accessibleNameForNode):

Canonical link: https://commits.webkit.org/262433@main