[webkit-changes] [WebKit/WebKit] 3bc64a: REGRESSION(259969 at main): Screen sharing is no long...

Eric Carlson noreply at github.com
Fri Mar 31 11:00:35 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3bc64a5506e3a0324da4b6c4b99e3e99f4b3a947
      https://github.com/WebKit/WebKit/commit/3bc64a5506e3a0324da4b6c4b99e3e99f4b3a947
  Author: Eric Carlson <eric.carlson at apple.com>
  Date:   2023-03-31 (Fri, 31 Mar 2023)

  Changed paths:
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/platform/mediastream/mac/CGDisplayStreamScreenCaptureSource.h
    M Source/WebCore/platform/mediastream/mac/CGDisplayStreamScreenCaptureSource.mm
    M Source/WebKit/UIProcess/mac/DisplayCaptureSessionManager.mm

  Log Message:
  -----------
  REGRESSION(259969 at main): Screen sharing is no longer working in public builds and causing UIProcess to crash
https://bugs.webkit.org/show_bug.cgi?id=254155
rdar://107265903

Reviewed by Youenn Fablet.

If the user agrees to share a screen on a version of macOS that doesn't have the
ScreenCaptureKit picker, share the main screen. This restores the behavior before
https://commits.webkit.org/259969@main.

* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/mediastream/mac/CGDisplayStreamScreenCaptureSource.h:
* Source/WebCore/platform/mediastream/mac/CGDisplayStreamScreenCaptureSource.mm:
(WebCore::CGDisplayStreamScreenCaptureSource::screenCaptureDeviceForMainDisplay):
* Source/WebKit/UIProcess/mac/DisplayCaptureSessionManager.mm:
(WebKit::DisplayCaptureSessionManager::promptForGetDisplayMedia):

Canonical link: https://commits.webkit.org/262424@main




More information about the webkit-changes mailing list