[webkit-changes] [WebKit/WebKit] dd0e31: [Margin-trim] Remove a virtual function call on th...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dd0e3196e1846ef93e142fd7867c2da57f6acdcd
      https://github.com/WebKit/WebKit/commit/dd0e3196e1846ef93e142fd7867c2da57f6acdcd
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-03-31 (Fri, 31 Mar 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderBlockFlow.cpp
    M Source/WebCore/rendering/RenderBlockFlow.h
    M Source/WebCore/rendering/RenderBox.h
    M Source/WebCore/rendering/RenderFlexibleBox.cpp
    M Source/WebCore/rendering/RenderFlexibleBox.h
    M Source/WebCore/rendering/RenderGrid.cpp
    M Source/WebCore/rendering/RenderGrid.h

  Log Message:
  -----------
  [Margin-trim] Remove a virtual function call on this rare property while computing margins
https://bugs.webkit.org/show_bug.cgi?id=254675

Reviewed by Chris Dumez.

Do not call the virtual function to check if the child is eligible for margin trimming, unless this (rare) CSS property is on the containing block/flex/grid container.

* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::isChildEligibleForMarginTrim const):
(WebCore::RenderBlockFlow::shouldTrimChildMargin const): Deleted.
* Source/WebCore/rendering/RenderBlockFlow.h:
* Source/WebCore/rendering/RenderBox.h:
(WebCore::RenderBox::isChildEligibleForMarginTrim const):
(WebCore::RenderBox::shouldTrimChildMargin const):
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::isChildEligibleForMarginTrim const):
(WebCore::RenderFlexibleBox::shouldTrimChildMargin const): Deleted.
* Source/WebCore/rendering/RenderFlexibleBox.h:
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::isChildEligibleForMarginTrim const):
(WebCore::RenderGrid::shouldTrimChildMargin const): Deleted.
* Source/WebCore/rendering/RenderGrid.h:

Canonical link: https://commits.webkit.org/262399@main