[webkit-changes] [WebKit/WebKit] f486be: Support rendering non-native <meter> in vertical w...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f486be28a10145a1cbb817618080f8f3481f2e0d
      https://github.com/WebKit/WebKit/commit/f486be28a10145a1cbb817618080f8f3481f2e0d
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-03-31 (Fri, 31 Mar 2023)

  Changed paths:
    M LayoutTests/fast/dom/HTMLMeterElement/meter-clone-expected.txt
    M LayoutTests/fast/dom/HTMLMeterElement/meter-clone.html
    M LayoutTests/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt
    M LayoutTests/fast/dom/HTMLMeterElement/meter-writing-mode-expected.html
    M LayoutTests/fast/dom/HTMLMeterElement/meter-writing-mode.html
    M LayoutTests/imported/w3c/resources/resource-files.json
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/meter-appearance-native-computed-style.optional-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/meter-appearance-native-computed-style.optional.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/meter-appearance-native-horizontal.optional-expected-mismatch.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/meter-appearance-native-horizontal.optional.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/meter-appearance-native-vertical.optional-expected-mismatch.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/meter-appearance-native-vertical.optional.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/w3c-import.log
    M LayoutTests/platform/glib/fast/dom/HTMLMeterElement/meter-element-expected.txt
    A LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-writing-modes/forms/meter-appearance-native-computed-style.optional-expected.txt
    M Source/WebCore/css/horizontalFormControls.css
    M Source/WebCore/css/html.css
    M Source/WebCore/html/HTMLMeterElement.cpp
    M Source/WebCore/html/shadow/meterElementShadow.css

  Log Message:
  -----------
  Support rendering non-native <meter> in vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=248182
rdar://102595455

Reviewed by Aditya Keerthi.

Use logical properties where needed.

Also enable <meter> rendering behind VerticalFormControls preference.

Native rendering will be done separately.

* LayoutTests/fast/dom/HTMLMeterElement/meter-clone-expected.txt:
* LayoutTests/fast/dom/HTMLMeterElement/meter-clone.html:
* LayoutTests/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt:
* LayoutTests/fast/dom/HTMLMeterElement/meter-writing-mode-expected.html:
* LayoutTests/fast/dom/HTMLMeterElement/meter-writing-mode.html:
Adjust tests accordingly.

* LayoutTests/imported/w3c/resources/resource-files.json:
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/meter-appearance-native-computed-style.optional-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/meter-appearance-native-computed-style.optional.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/meter-appearance-native-horizontal.optional-expected-mismatch.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/meter-appearance-native-horizontal.optional.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/meter-appearance-native-vertical.optional-expected-mismatch.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/meter-appearance-native-vertical.optional.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/w3c-import.log:
* LayoutTests/platform/glib/fast/dom/HTMLMeterElement/meter-element-expected.txt:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-writing-modes/forms/meter-appearance-native-computed-style.optional-expected.txt: Added.
Imported from WPT upstream repo.

* Source/WebCore/css/horizontalFormControls.css:
(@namespace "http://www.w3.org/1999/xhtml";):
* Source/WebCore/css/html.css:
(select, button, input:is([type="button"], [type="submit"], [type="reset"], [type="file"])):
(meter):
(select, button, meter, input:is([type="button"], [type="submit"], [type="reset"], [type="file"])): Deleted.
* Source/WebCore/html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::didElementStateChange):
* Source/WebCore/html/shadow/meterElementShadow.css:
(div#value):
(div#value.suboptimum): Remove some redundant rules covered by div#value
(div#value.even-less-good):

Canonical link: https://commits.webkit.org/262395@main