[webkit-changes] [WebKit/WebKit] 5536f0: [Cocoa] Log font attributes to the TextShaping log...

Myles C. Maxfield noreply at github.com
Thu Mar 30 16:57:57 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5536f0059db88ad45ec7d63bb741c018a007bb1e
      https://github.com/WebKit/WebKit/commit/5536f0059db88ad45ec7d63bb741c018a007bb1e
  Author: Myles C. Maxfield <mmaxfield at apple.com>
  Date:   2023-03-30 (Thu, 30 Mar 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/coretext/FontCoreText.cpp
    M Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm

  Log Message:
  -----------
  [Cocoa] Log font attributes to the TextShaping log channel
https://bugs.webkit.org/show_bug.cgi?id=254188
rdar://106965417

Reviewed by Simon Fraser.

Previously, we were just logging the font name, but it's more helpful to log all the font attributes.

This extra logging helped me figure out what was going on with https://bugs.webkit.org/show_bug.cgi?id=254146.

No tests because there is no behavior change.

* Source/WebCore/platform/graphics/coretext/FontCoreText.cpp:
(WebCore::Font::applyTransforms const):
* Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):

Canonical link: https://commits.webkit.org/262377@main




More information about the webkit-changes mailing list