[webkit-changes] [WebKit/WebKit] a915cb: REGRESSION (262263 at main): Caused the GPU process t...

Simon Fraser noreply at github.com
Thu Mar 30 16:11:51 PDT 2023 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a915cbcacc25ab74dca64eee7101b1c27d957a4d
      https://github.com/WebKit/WebKit/commit/a915cbcacc25ab74dca64eee7101b1c27d957a4d
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2023-03-30 (Thu, 30 Mar 2023)

  Changed paths:
    M Source/WebCore/css/CSSFontFaceSource.h
    M Source/WebCore/loader/cache/CachedFont.cpp
    M Source/WebCore/loader/cache/CachedFont.h
    M Source/WebCore/platform/graphics/Font.cpp
    M Source/WebCore/platform/graphics/Font.h
    M Source/WebCore/platform/graphics/FontCustomPlatformData.h
    M Source/WebCore/platform/graphics/FontPlatformData.cpp
    M Source/WebCore/platform/graphics/FontPlatformData.h
    M Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp
    M Source/WebCore/platform/graphics/coretext/FontCoreText.cpp
    M Source/WebCore/platform/graphics/coretext/FontPlatformDataCoreText.cpp
    M Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp
    M Source/WebCore/platform/graphics/mac/FontCustomPlatformDataMac.cpp
    M Source/WebCore/platform/graphics/win/FontCustomPlatformDataWin.cpp
    M Source/WebCore/platform/graphics/win/FontPlatformDataCairoWin.cpp
    M Source/WebCore/platform/graphics/win/FontPlatformDataWin.cpp
    M Source/WebCore/workers/WorkerFontLoadRequest.h
    M Source/WebKit/GPUProcess/graphics/QualifiedResourceHeap.h
    M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp
    M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h
    M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in
    M Source/WebKit/GPUProcess/graphics/RemoteResourceCache.cpp
    M Source/WebKit/GPUProcess/graphics/RemoteResourceCache.h
    M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm
    M Source/WebKit/Shared/WebCoreArgumentCoders.cpp
    M Source/WebKit/Shared/WebCoreArgumentCoders.h
    M Source/WebKit/Shared/cf/ArgumentCodersCF.cpp
    M Source/WebKit/Shared/playstation/WebCoreArgumentCodersPlayStation.cpp
    M Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp
    M Source/WebKit/Shared/win/WebCoreArgumentCodersWin.cpp
    M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp
    M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h
    M Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp
    M Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.h

  Log Message:
  -----------
  REGRESSION (262263 at main): Caused the GPU process to kill the web process sometimes
https://bugs.webkit.org/show_bug.cgi?id=254774
<rdar://107412422>

Unreviewed revert.

* Source/WebCore/css/CSSFontFaceSource.h:
* Source/WebCore/loader/cache/CachedFont.cpp:
(WebCore::CachedFont::createCustomFontData):
* Source/WebCore/loader/cache/CachedFont.h:
* Source/WebCore/platform/graphics/Font.cpp:
(WebCore::Font::Font):
(WebCore::Font::renderingResourceIdentifier const):
(WebCore::m_shouldNotBeUsedForArabic): Deleted.
(WebCore::Font::Attributes::ensureRenderingResourceIdentifier const): Deleted.
* Source/WebCore/platform/graphics/Font.h:
(WebCore::Font::isTextOrientationFallback const):
(WebCore::Font::origin const):
(WebCore::Font::isInterstitial const):
(WebCore::Font::visibility const):
(WebCore::Font::attributes const): Deleted.
* Source/WebCore/platform/graphics/FontCustomPlatformData.h:
(WebCore::FontCustomPlatformData::FontCustomPlatformData):
* Source/WebCore/platform/graphics/FontPlatformData.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::creationData const): Deleted.
* Source/WebCore/platform/graphics/FontPlatformData.h:
(WebCore::FontPlatformData::creationData const):
(WebCore::FontPlatformData::Attributes::Attributes): Deleted.
(WebCore::FontPlatformData::customPlatformData const): Deleted.
* Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontCache::systemFallbackForCharacters):
* Source/WebCore/platform/graphics/coretext/FontCoreText.cpp:
(WebCore::createDerivativeFont):
(WebCore::Font::createFontWithoutSynthesizableFeatures const):
(WebCore::Font::platformCreateScaledFont const):
* Source/WebCore/platform/graphics/coretext/FontPlatformDataCoreText.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::findFontDescriptor): Deleted.
(WebCore::createCTFont): Deleted.
(WebCore::FontPlatformData::create): Deleted.
(WebCore::FontPlatformData::attributes const): Deleted.
* Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
(WebCore::createFontCustomPlatformData):
* Source/WebCore/platform/graphics/mac/FontCustomPlatformDataMac.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
(WebCore::createFontCustomPlatformData):
* Source/WebCore/platform/graphics/win/FontCustomPlatformDataWin.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
(WebCore::createFontCustomPlatformData):
* Source/WebCore/platform/graphics/win/FontPlatformDataCairoWin.cpp:
(WebCore::FontPlatformData::FontPlatformData):
* Source/WebCore/platform/graphics/win/FontPlatformDataWin.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::create): Deleted.
(WebCore::FontPlatformData::attributes const): Deleted.
* Source/WebCore/workers/WorkerFontLoadRequest.h:
* Source/WebKit/GPUProcess/graphics/QualifiedResourceHeap.h:
(WebKit::QualifiedResourceHeap::releaseAllResources):
(WebKit::QualifiedResourceHeap::checkInvariants const):
(WebKit::QualifiedResourceHeap::getFontCustomPlatformData const): Deleted.
(WebKit::QualifiedResourceHeap::removeFontCustomPlatformData): Deleted.
* Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::cacheFont):
(WebKit::RemoteRenderingBackend::cacheFontCustomPlatformData): Deleted.
(WebKit::RemoteRenderingBackend::cacheFontCustomPlatformDataWithQualifiedIdentifier): Deleted.
* Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h:
* Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in:
* Source/WebKit/GPUProcess/graphics/RemoteResourceCache.cpp:
(WebKit::RemoteResourceCache::releaseRenderingResource):
(WebKit::RemoteResourceCache::cacheFontCustomPlatformData): Deleted.
(WebKit::RemoteResourceCache::cachedFontCustomPlatformData const): Deleted.
* Source/WebKit/GPUProcess/graphics/RemoteResourceCache.h:
* Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
(IPC::ArgumentCoder<WebCore::Font>::decodePlatformData):
(IPC::ArgumentCoder<WebCore::FontCustomPlatformData>::encodePlatformData): Deleted.
(IPC::ArgumentCoder<WebCore::FontCustomPlatformData>::decodePlatformData): Deleted.
(IPC::ArgumentCoder<WebCore::FontPlatformData::Attributes>::encodePlatformData): Deleted.
(IPC::ArgumentCoder<WebCore::FontPlatformData::Attributes>::decodePlatformData): Deleted.
* Source/WebKit/Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<WebCore::Font>::encode):
(IPC::ArgumentCoder<Font>::decode):
(IPC::ArgumentCoder<WebCore::Font::Attributes>::encode): Deleted.
(IPC::ArgumentCoder<Font::Attributes>::decode): Deleted.
(IPC::ArgumentCoder<WebCore::FontCustomPlatformData>::encode): Deleted.
(IPC::ArgumentCoder<FontCustomPlatformData>::decode): Deleted.
(IPC::ArgumentCoder<WebCore::FontPlatformData::Attributes>::encode): Deleted.
(IPC::ArgumentCoder<FontPlatformData::Attributes>::decode): Deleted.
* Source/WebKit/Shared/WebCoreArgumentCoders.h:
* Source/WebKit/Shared/cf/ArgumentCodersCF.cpp:
(IPC::ArgumentCoder<CFStringRef>::encode):
(IPC::ArgumentCoder<RetainPtr<CFStringRef>>::decode):
* Source/WebKit/Shared/playstation/WebCoreArgumentCodersPlayStation.cpp:
(IPC::ArgumentCoder<WebCore::FontCustomPlatformData>::encodePlatformData): Deleted.
(IPC::ArgumentCoder<WebCore::FontCustomPlatformData>::decodePlatformData): Deleted.
(IPC::ArgumentCoder<WebCore::FontPlatformData::Attributes>::encodePlatformData): Deleted.
(IPC::ArgumentCoder<WebCore::FontPlatformData::Attributes>::decodePlatformData): Deleted.
* Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp:
(IPC::ArgumentCoder<WebCore::FontCustomPlatformData>::encodePlatformData): Deleted.
(IPC::ArgumentCoder<WebCore::FontCustomPlatformData>::decodePlatformData): Deleted.
(IPC::ArgumentCoder<WebCore::FontPlatformData::Attributes>::encodePlatformData): Deleted.
(IPC::ArgumentCoder<WebCore::FontPlatformData::Attributes>::decodePlatformData): Deleted.
* Source/WebKit/Shared/win/WebCoreArgumentCodersWin.cpp:
(IPC::ArgumentCoder<Font>::decodePlatformData):
(IPC::ArgumentCoder<WebCore::FontCustomPlatformData>::encodePlatformData): Deleted.
(IPC::ArgumentCoder<WebCore::FontCustomPlatformData>::decodePlatformData): Deleted.
(IPC::ArgumentCoder<WebCore::FontPlatformData::Attributes>::encodePlatformData): Deleted.
(IPC::ArgumentCoder<WebCore::FontPlatformData::Attributes>::decodePlatformData): Deleted.
* Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::cacheFont):
(WebKit::RemoteRenderingBackendProxy::cacheFontCustomPlatformData): Deleted.
* Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp:
(WebKit::RemoteResourceCacheProxy::recordFontUse):
(WebKit::RemoteResourceCacheProxy::prepareForNextRenderingUpdate):
(WebKit::RemoteResourceCacheProxy::finalizeRenderingUpdateForFonts):
(WebKit::RemoteResourceCacheProxy::recordFontCustomPlatformDataUse): Deleted.
* Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.h:

Canonical link: https://commits.webkit.org/262371@main

More information about the webkit-changes mailing list