[webkit-changes] [WebKit/WebKit] a53f70: Avoid calling hasAttributeWithoutSynchronization()...

Ahmad Saleem noreply at github.com
Thu Mar 30 14:45:07 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a53f705a48ab788f88e35493ff5e878738387bdc
      https://github.com/WebKit/WebKit/commit/a53f705a48ab788f88e35493ff5e878738387bdc
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-03-30 (Thu, 30 Mar 2023)

  Changed paths:
    M Source/WebCore/html/HTMLAnchorElement.cpp

  Log Message:
  -----------
  Avoid calling hasAttributeWithoutSynchronization() and then attributeWithoutSynchronization() for performance in HTMLAnchorElement.cpp

https://bugs.webkit.org/show_bug.cgi?id=254751

Reviewed by Chris Dumez and Aditya Keerthi.

Partial Merge - https://chromium.googlesource.com/chromium/blink/+/f28d0fba0e523c1669c48354a416a091c5f062e0

It is to modify by avoid calling hasAttributeWithoutSynchronization and
attributeWithoutSynchronization for performance.
This causes the attribute to be looked up (linear search) twice instead
of once if we call 'attributeWithoutSynchronization' directly and
then check if the returned is null.
Additionally, do early return if 'hyperlinkAuditingEnabled' is not enabled.

* Source/WebCore/html/HTMLAnchorElement.cpp:
(HTMLAnchorElement::sendPings):

Canonical link: https://commits.webkit.org/262367@main




More information about the webkit-changes mailing list