[webkit-changes] [WebKit/WebKit] 5e8cab: Add missing simple pseudo elements to selector com...

Antti Koivisto noreply at github.com
Thu Mar 30 12:07:33 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5e8cabcf89497516ecfb68ea65ac1be985874faa
      https://github.com/WebKit/WebKit/commit/5e8cabcf89497516ecfb68ea65ac1be985874faa
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-03-30 (Thu, 30 Mar 2023)

  Changed paths:
    M Source/WebCore/cssjit/SelectorCompiler.cpp

  Log Message:
  -----------
  Add missing simple pseudo elements to selector compiler
https://bugs.webkit.org/show_bug.cgi?id=254671
rdar://107315560

Reviewed by Yusuke Suzuki.

* Source/WebCore/cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoElementPseudoClassType):

This function just return false because ::pseudo-element:pseudo-class case is (per comments) not handled by the compiler at the moment.

(WebCore::SelectorCompiler::constructFragmentsInternal):

Remove the isScrollbarPseudoElement test. It is not needed, only valid selectors are allowed by the parser.
Newly enabled pseudo-elements either conceptually always match or are only tested against elements that match (WebKitCustom pseudos).
Remove the default case so these stay better up to date.

(WebCore::SelectorCompiler::addScrollbarPseudoClassType): Deleted.
(WebCore::SelectorCompiler::isScrollbarPseudoElement): Deleted.

Canonical link: https://commits.webkit.org/262357@main




More information about the webkit-changes mailing list