[webkit-changes] [WebKit/WebKit] 97c802: webgl/1.0.x/conformance/extensions/webgl-multi-dra...

Kimmo Kinnunen noreply at github.com
Thu Mar 30 03:03:23 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 97c802f322e5825b71a7b58699c589e1fa23c1f7
      https://github.com/WebKit/WebKit/commit/97c802f322e5825b71a7b58699c589e1fa23c1f7
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2023-03-30 (Thu, 30 Mar 2023)

  Changed paths:
    M LayoutTests/webgl/resources/webkit-webgl-test-harness.js

  Log Message:
  -----------
  webgl/1.0.x/conformance/extensions/webgl-multi-draw.html times out frequently
https://bugs.webkit.org/show_bug.cgi?id=254660
rdar://107364131

Reviewed by Matt Woodrow.

WebGL tests are run inside a iframe in order to pass the context version
as an url parameter. The test assertion messages
are copied to the wrapper DOM in order to report the failures to
layout tests.

Avoid using <ul><li>message</li> ... in the copied wrapper messages.
list items update the marker number (RenderListItem::updateListMarkerNumbers())
for each update for each message. This appears to be very slow on Debug.
The test webgl-multi-draw.html has 11000 messages, so this test times out
frequently on Debug.

Instead, report the messages to divs once the test finishes.

Reduces the debug runtime of webgl-multi-draw.html from 37s to 11s.

* LayoutTests/webgl/resources/webkit-webgl-test-harness.js:
(window.webglTestHarness.reportResults):
(window.webglTestHarness.notifyFinished):
(list): Deleted.

Canonical link: https://commits.webkit.org/262318@main




More information about the webkit-changes mailing list