[webkit-changes] [WebKit/WebKit] f06787: Entering/Leaving YouTube fullscreen causes the vid...

Jer Noble noreply at github.com
Wed Mar 29 23:29:53 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f06787f3c33ac4905086d4083ce54762da5e28de
      https://github.com/WebKit/WebKit/commit/f06787f3c33ac4905086d4083ce54762da5e28de
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2023-03-29 (Wed, 29 Mar 2023)

  Changed paths:
    M Source/WebKit/WebProcess/GPU/media/cocoa/VideoLayerRemoteCocoa.mm

  Log Message:
  -----------
  Entering/Leaving YouTube fullscreen causes the video to not scale fully to screen edges
https://bugs.webkit.org/show_bug.cgi?id=254686
rdar://102970285

Reviewed by Eric Carlson.

Sometimes the test for CGRectEqualToRect(self.videoLayerFrame, self.bounds) will unexpectedly
succeed, leaving the video sublayer with the incorrect size and transform. Instead, this code
should match that of WebAVPlayerLayer, and test against videoSublayer.bounds, since that's
the value that is changed by the rest of the code.

* Source/WebKit/WebProcess/GPU/media/cocoa/VideoLayerRemoteCocoa.mm:
(-[WKVideoLayerRemote resolveBounds]):

Canonical link: https://commits.webkit.org/262311@main




More information about the webkit-changes mailing list