[webkit-changes] [WebKit/WebKit] 472644: [css-conditional] Fix unknown function parsing in ...

Tim Nguyen noreply at github.com
Wed Mar 29 21:07:36 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4726444d4de9244dc650867158f151dadab41a5a
      https://github.com/WebKit/WebKit/commit/4726444d4de9244dc650867158f151dadab41a5a
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-03-29 (Wed, 29 Mar 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/js/supports-conditionText-expected.txt
    M Source/WebCore/css/parser/CSSSupportsParser.cpp

  Log Message:
  -----------
  [css-conditional] Fix unknown function parsing in @supports rule
https://bugs.webkit.org/show_bug.cgi?id=254716
rdar://107397723

Reviewed by Simon Fraser.

Previously, we were only parsing unknown functions in consumeSupportsFeatureOrGeneralEnclosed, but there is another codepath where we parse functions,
which is consumeConditionInParenthesis. Move logic from consumeSupportsFeatureOrGeneralEnclosed to consumeSupportsFunction in order to cover both codepaths.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/js/supports-conditionText-expected.txt:
* Source/WebCore/css/parser/CSSSupportsParser.cpp:
(WebCore::CSSSupportsParser::consumeSupportsFunction):
(WebCore::CSSSupportsParser::consumeSupportsFeatureOrGeneralEnclosed):

Canonical link: https://commits.webkit.org/262308@main




More information about the webkit-changes mailing list