[webkit-changes] [WebKit/WebKit] 2e399b: WKWebAuthenticationPanel: attributesArrayRef is no...

[Rose]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2e399bd0c6f4aaf24907cf10a9067e0b7ea6c8fd
      https://github.com/WebKit/WebKit/commit/2e399bd0c6f4aaf24907cf10a9067e0b7ea6c8fd
  Author: Rose <83477269+AtariDreams at users.noreply.github.com>
  Date:   2023-03-29 (Wed, 29 Mar 2023)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm

  Log Message:
  -----------
  WKWebAuthenticationPanel: attributesArrayRef is not released
https://bugs.webkit.org/show_bug.cgi?id=254667

Reviewed by Chris Dumez.

Normally, the result of SecItemCopyMatching is assigned to a smart
pointer, and/or released later in the code. However, there is one
instance where that does not happen, and the value is simply bridged to
an NSDictionary without any change in ownership. This results in said
result being leaked in memory.

* Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
  (exportLocalAuthenticatorCredentialWithGroupAndID): Assign
  attributesArrayRef to a smart pointer.

Canonical link: https://commits.webkit.org/262299@main