[webkit-changes] [WebKit/WebKit] 55d490: Category and subsystem is not being logged

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 55d490a268c7a5fe34fc9ac10fcc54e8063e1e19
      https://github.com/WebKit/WebKit/commit/55d490a268c7a5fe34fc9ac10fcc54e8063e1e19
  Author: Per Arne Vollan <pvollan at apple.com>
  Date:   2023-03-29 (Wed, 29 Mar 2023)

  Changed paths:
    M Source/WTF/wtf/spi/cocoa/OSLogSPI.h
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
    M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm

  Log Message:
  -----------
  Category and subsystem is not being logged
https://bugs.webkit.org/show_bug.cgi?id=253579
rdar://106762697

Reviewed by Geoffrey Garen.

Category and subsystem is not being logged when the WebContent process is blocking access to logd in
the sandbox and forwarding logs to the Networking process. This patch sends the category and subsystem
along with the WebContent PID from the log hook to the Networking process, where the matching log
object will be used. A new function is added to do a sanity check of the strings sent. This patch does
not enable this feature, since we still need to evaluate if our logging needs are maintained.

* Source/WTF/wtf/spi/cocoa/OSLogSPI.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::validatedASCIIString):
(WebKit::NetworkConnectionToWebProcess::logOnBehalfOfWebContent):
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::registerLogHook):

Canonical link: https://commits.webkit.org/262295@main