[webkit-changes] [WebKit/WebKit] 948db0: innerHTML serialization should not have a special ...
Ahmad Saleem
noreply at github.com
Wed Mar 29 04:35:19 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 948db072bd947394d613b7a3f0fa59de800192be
https://github.com/WebKit/WebKit/commit/948db072bd947394d613b7a3f0fa59de800192be
Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
R LayoutTests/fast/innerHTML/javascript-url-expected.txt
R LayoutTests/fast/innerHTML/javascript-url.html
M LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-column-017-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/html/syntax/serializing-html-fragments/serializing-expected.txt
M LayoutTests/platform/ios/css3/flexbox/flexitem-expected.txt
M Source/WebCore/editing/MarkupAccumulator.cpp
M Source/WebCore/editing/MarkupAccumulator.h
Log Message:
-----------
innerHTML serialization should not have a special handling for javascript: URLs
https://bugs.webkit.org/show_bug.cgi?id=254617
Reviewed by Ryosuke Niwa.
This patch aligns WebKit behavior with Blink / Chromium and Gecko / Firefox.
Merge - https://chromium.googlesource.com/chromium/src.git/+/a806a0593906b75b9396d3bbd092bdda9161bf4c
The HTML specification [1] doesn't have such special handling, and
Firefox and Chrome conforms to the specification.
This also remove fast/innerHTML/javascript-url.html because javascript: URLs are
not special any longer.
[1] https://html.spec.whatwg.org/multipage/parsing.html#serialising-html-fragments:attribute's-serialised-name
* Source/WebCore/editing/MarkupAccumulator.cpp:
(MarkupAccumulator::appendQuotedURLAttributeValue): Deleted
(MarkupAccumulator::appendAttribute): Update to remove special handling
* Source/WebCore/editing/MarkupAccumulator.h: Delete 'appendQuotedURLAttributeValue'
* LayoutTests/imported/w3c/web-platform-tests/html/syntax/serializing-html-fragments/serializing-expected.txt: Rebaselined
* LayoutTests/fast/innerHTML/javascript-url.html: Deleted
* LayoutTests/fast/innerHTML/javascript-url-expected.txt: Deleted
* LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-column-017-expected.txt: Rebaselined
* LayoutTests/platform/ios/css3/flexbox/flexitem-expected.txt: Rebaselined
Canonical link: https://commits.webkit.org/262267@main
More information about the webkit-changes
mailing list