[webkit-changes] [WebKit/WebKit] 2eff4b: @counter-style: extends system should always exten...

Vitor Roriz noreply at github.com
Wed Mar 29 02:27:32 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2eff4ba097378064ae626ddfb29d7ad931eb1931
      https://github.com/WebKit/WebKit/commit/2eff4ba097378064ae626ddfb29d7ad931eb1931
  Author: Vitor Roriz <vitor.roriz at apple.com>
  Date:   2023-03-29 (Wed, 29 Mar 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-at-rule/system-extends-fixed-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-at-rule/system-extends-fixed-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-at-rule/system-extends-fixed.html
    M Source/WebCore/css/CSSCounterStyle.cpp
    M Source/WebCore/css/CSSCounterStyle.h

  Log Message:
  -----------
  @counter-style: extends system should always extend first symbol for fixed system
https://bugs.webkit.org/show_bug.cgi?id=254597
rdar://107320608

Reviewed by Tim Nguyen.

When extending a system: fixed, the first symbol for the fixed system
should always be extended (copied from the counter being extended), since it is impossible to explicitly define
a first symbol when the counter style's system is extends.

* LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-at-rule/system-extends-fixed-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-at-rule/system-extends-fixed-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-at-rule/system-extends-fixed.html: Added.
* Source/WebCore/css/CSSCounterStyle.cpp:
(WebCore::CSSCounterStyle::extendAndResolve):
* Source/WebCore/css/CSSCounterStyle.h:
(WebCore::CSSCounterStyle::setFirstSymbolValueForFixedSystem):

Canonical link: https://commits.webkit.org/262264@main




More information about the webkit-changes mailing list