[webkit-changes] [WebKit/WebKit] d6c454: Remove redundant quirk on ignoring centered text w...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d6c4544acc9602b763d2fc0ffdacea5730bcfab1
      https://github.com/WebKit/WebKit/commit/d6c4544acc9602b763d2fc0ffdacea5730bcfab1
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-03-28 (Tue, 28 Mar 2023)

  Changed paths:
    R LayoutTests/fast/block/legacy-text-align-position-quirk-expected.html
    R LayoutTests/fast/block/legacy-text-align-position-quirk.html
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/rendering/RenderBlockFlow.cpp
    M Source/WebKit/UIProcess/API/C/WKPreferences.cpp
    M Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
    M Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
    M Source/WebKitLegacy/mac/WebView/WebPreferences.mm
    M Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h

  Log Message:
  -----------
  Remove redundant quirk on ignoring centered text when positioning
https://bugs.webkit.org/show_bug.cgi?id=254608

Reviewed by Simon Fraser.

This quirk was originally introduced to support a non-standard text-align behavior on out-of-flow positioned boxes (essentially ignoring 'text-align' on 'position: absolute/fixed').
It was exercised by some old book content but it is not used anymore (see <rdar://15427571> and webkit.org/b/124522 for the original use case).

* LayoutTests/fast/block/legacy-text-align-position-quirk-expected.html: Removed.
* LayoutTests/fast/block/legacy-text-align-position-quirk.html: Removed.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::outputLineTree const):
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::startAlignedOffsetForLine):
* Source/WebKit/UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesUseLegacyTextAlignPositionedElementBehavior): Deleted.
(WKPreferencesSetUseLegacyTextAlignPositionedElementBehavior): Deleted.
* Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h:
* Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h:
* Source/WebKitLegacy/mac/WebView/WebPreferences.mm:
(-[WebPreferences useLegacyTextAlignPositionedElementBehavior]): Deleted.
(-[WebPreferences setUseLegacyTextAlignPositionedElementBehavior:]): Deleted.
* Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h:

Canonical link: https://commits.webkit.org/262251@main