[webkit-changes] [WebKit/WebKit] ee9e30: [UI-side compositing] Two RTL scrolling tests fail

Ryosuke Niwa noreply at github.com
Tue Mar 28 16:27:55 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ee9e3014c93a5302d2d32370ab1b0a8565483cd4
      https://github.com/WebKit/WebKit/commit/ee9e3014c93a5302d2d32370ab1b0a8565483cd4
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-03-28 (Tue, 28 Mar 2023)

  Changed paths:
    M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.mm

  Log Message:
  -----------
  [UI-side compositing] Two RTL scrolling tests fail
https://bugs.webkit.org/show_bug.cgi?id=254618

Reviewed by Simon Fraser.

The bug was caused by the confusion of scroll position vs. offset.
Here, we're converting to offset so we need to subtract the scroll origin,
which we accomplish by not moving by scroll origin in the first place.

* Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.mm:
(WebKit::RemoteScrollingTreeMac::scrollingNodeForPoint):

Canonical link: https://commits.webkit.org/262244@main




More information about the webkit-changes mailing list