[webkit-changes] [WebKit/WebKit] 126b01: [JSC] Fix Paren Context allocation and use with Du...

[Michael Saboff]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 126b01e1d8ac27d37bf0dd8bf5c16423587b2c82
      https://github.com/WebKit/WebKit/commit/126b01e1d8ac27d37bf0dd8bf5c16423587b2c82
  Author: Michael Saboff <msaboff at apple.com>
  Date:   2023-03-28 (Tue, 28 Mar 2023)

  Changed paths:
    M JSTests/stress/regexp-duplicate-named-captures.js
    M Source/JavaScriptCore/yarr/YarrJIT.cpp

  Log Message:
  -----------
  [JSC] Fix Paren Context allocation and use with Duplicate Named Capture groups
https://bugs.webkit.org/show_bug.cgi?id=254600
rdar://107180725

Reviewed by Yusuke Suzuki.

Fixed two issues in the YARR JIT with Paren contextes and duplicate named capture IDs.

The first is that we weren't including the space needed for duplicateNamedCaptures in ParenContext::sizeFor().
This could cause us to reuse frame slots.

The second issue is that we were restoring the non-existent 0 duplicate named capture in YarrGenerator::restoreParenContext().
Duplicate named capture IDs start at 1.

* JSTests/stress/regexp-duplicate-named-captures.js:
* Source/JavaScriptCore/yarr/YarrJIT.cpp:

Canonical link: https://commits.webkit.org/262239@main