[webkit-changes] [WebKit/WebKit] 927cb4: [Wasm-GC] Avoid stack consistency checking in LLIn...

[Tim Chevalier]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 927cb4227a3673e681c36659637e1f5a78cd8f56
      https://github.com/WebKit/WebKit/commit/927cb4227a3673e681c36659637e1f5a78cd8f56
  Author: Tim Chevalier <tjc at igalia.com>
  Date:   2023-03-28 (Tue, 28 Mar 2023)

  Changed paths:
    A JSTests/wasm/gc/bug254226.js
    M Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp

  Log Message:
  -----------
  [Wasm-GC] Avoid stack consistency checking in LLIntGenerator::addStructNew()
https://bugs.webkit.org/show_bug.cgi?id=254226

Reviewed by Justin Michaud.

`addStructNew()` was failing in debug mode if called with a non-empty parser
stack, because pushing the arguments results in LLInt's view of the stack
getting out of sync with the parser's stack. Changed it to use
`walkExpressionStack()`, similarly to `addThrow()`.

* JSTests/wasm/gc/bug254226.js: Added.
(module):
(testNestedStruct):
* Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp:
(JSC::Wasm::LLIntGenerator::addStructNew):

Canonical link: https://commits.webkit.org/262236@main