[webkit-changes] [WebKit/WebKit] 3d1454: Unreviewed crash fix for Windows Debug

Fujii Hironori noreply at github.com
Tue Mar 28 14:17:48 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3d14545676fe78a6e2e8067347f226f03ac78712
      https://github.com/WebKit/WebKit/commit/3d14545676fe78a6e2e8067347f226f03ac78712
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2023-03-28 (Tue, 28 Mar 2023)

  Changed paths:
    M Source/JavaScriptCore/jit/CCallHelpers.h

  Log Message:
  -----------
  Unreviewed crash fix for Windows Debug
https://bugs.webkit.org/show_bug.cgi?id=254573

The following assertion were failing for Windows Debug.

> ASSERTION FAILED: currentGPRArgument >= GPRInfo::numberOfArgumentRegisters || currentFPRArgument >= FPRInfo::numberOfArgumentRegisters
> Source\JavaScriptCore\jit\CCallHelpers.h(371) : JSC::CCallHelpers::calculatePokeOffset

This assertion isn't valid for Windows. Conditioned out the assertion
for Windows.

* Source/JavaScriptCore/jit/CCallHelpers.h:
(JSC::CCallHelpers::calculatePokeOffset):

Canonical link: https://commits.webkit.org/262233@main




More information about the webkit-changes mailing list