[webkit-changes] [WebKit/WebKit] 4dc62c: HTML Comments after </body> are placed at the bott...

Tue Mar 28 09:27:54 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4dc62c7c9b46afea3f1ebda36f85d13dcd158ee8
      https://github.com/WebKit/WebKit/commit/4dc62c7c9b46afea3f1ebda36f85d13dcd158ee8
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-03-28 (Tue, 28 Mar 2023)

  Changed paths:
    M LayoutTests/editing/selection/doubleclick-crash-expected.txt
    M LayoutTests/html5lib/resources/webkit01.dat
    M LayoutTests/platform/gtk/editing/selection/doubleclick-crash-expected.txt
    M Source/WebCore/html/parser/HTMLTreeBuilder.cpp
    M Source/WebCore/html/parser/HTMLTreeBuilder.h

  Log Message:
  -----------
  HTML Comments after </body> are placed at the bottom of the <body> contents
https://bugs.webkit.org/show_bug.cgi?id=79273
rdar://95557786

Reviewed by Ryosuke Niwa.

Consume whitespace in the "after body" and "after after body" modes so following comments get inserted after the body element.

Tests are from https://chromium.googlesource.com/chromium/src/+/9a75bc03766976f883731f08d52ae70204f94caa%5E%21/ and contrary to the assertion there do not pass in WebKit today.

* LayoutTests/editing/selection/doubleclick-crash-expected.txt:
* LayoutTests/html5lib/resources/webkit01.dat:
* LayoutTests/platform/gtk/editing/selection/doubleclick-crash-expected.txt:
* Source/WebCore/html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::consumeAndInsertWhitespace):

Abstracts a common operation.

(WebCore::HTMLTreeBuilder::processCharacterBuffer):
(WebCore::HTMLTreeBuilder::processTokenInForeignContent):
* Source/WebCore/html/parser/HTMLTreeBuilder.h:

Canonical link: https://commits.webkit.org/262222@main