[webkit-changes] [WebKit/WebKit] f73dcb: hasTrimmedMargin should return false for out of fl...

[Sammy Gill]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f73dcb9ce6b70f402f0eaf7202a6d682cd68b011
      https://github.com/WebKit/WebKit/commit/f73dcb9ce6b70f402f0eaf7202a6d682cd68b011
  Author: Sammy Gill <sammy.gill at apple.com>
  Date:   2023-03-28 (Tue, 28 Mar 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderBox.cpp

  Log Message:
  -----------
  hasTrimmedMargin should return false for out of flow boxes
https://bugs.webkit.org/show_bug.cgi?id=254540
rdar://107277206

Reviewed by Alan Baradlay.

The margin-trim spec says that the property only applies to
in-flow boxes and floats, so the hasTrimmedMargin functions should
return false if the call to isInFlow returns false.

Without this test cases may trigger an assert in the code that guards
the rest of the logic in the functions. css3/flexbox/insert-text-crash
is an example of a test case that would trigger the assert due to the
absolutely positioned box.

* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::hasTrimmedMargin const):

Canonical link: https://commits.webkit.org/262217@main