[webkit-changes] [WebKit/WebKit] 889edf: [WGSL] Textures and samplers shouldn't be references

Tadeu Zagallo noreply at github.com
Tue Mar 28 02:02:31 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 889edf206f1a3946daf6664d6b2e5870c5c9cc28
      https://github.com/WebKit/WebKit/commit/889edf206f1a3946daf6664d6b2e5870c5c9cc28
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-03-28 (Tue, 28 Mar 2023)

  Changed paths:
    M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp

  Log Message:
  -----------
  [WGSL] Textures and samplers shouldn't be references
https://bugs.webkit.org/show_bug.cgi?id=254425
rdar://107188253

Reviewed by Myles C. Maxfield.

When converting globals to argument buffers, most values become references, but
that doesn't apply to textures and samplers. Add logic to check the type of the
global instead of unconditionally converting it to a reference.

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::insertStructs):

Canonical link: https://commits.webkit.org/262200@main




More information about the webkit-changes mailing list