[webkit-changes] [WebKit/WebKit] 88070f: [JSC] Add ImplementationVisibility to Wasm::Callee

Yusuke Suzuki noreply at github.com
Mon Mar 27 19:05:51 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 88070f054a4e88c1dbfc9eb2718256c3e41d0ce2
      https://github.com/WebKit/WebKit/commit/88070f054a4e88c1dbfc9eb2718256c3e41d0ce2
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2023-03-27 (Mon, 27 Mar 2023)

  Changed paths:
    M JSTests/wasm/function-tests/nameSection.js
    M JSTests/wasm/function-tests/stack-trace.js
    M JSTests/wasm/function-tests/trap-after-cross-instance-call.js
    M JSTests/wasm/function-tests/trap-load-2.js
    M JSTests/wasm/function-tests/trap-load-shared.js
    M JSTests/wasm/function-tests/trap-load.js
    M JSTests/wasm/stress/simple-inline-stacktrace-2.js
    M JSTests/wasm/stress/simple-inline-stacktrace-with-catch-2.js
    M JSTests/wasm/stress/simple-inline-stacktrace-with-catch.js
    M JSTests/wasm/stress/simple-inline-stacktrace.js
    M Source/JavaScriptCore/interpreter/StackVisitor.cpp
    M Source/JavaScriptCore/wasm/WasmCallee.cpp
    M Source/JavaScriptCore/wasm/WasmCallee.h

  Log Message:
  -----------
  [JSC] Add ImplementationVisibility to Wasm::Callee
https://bugs.webkit.org/show_bug.cgi?id=254455
rdar://107213008

Reviewed by Justin Michaud.

Add ImplementationVisibility to Wasm::Callee, and hide internal wasm-stubs from stacktrace.
This will be extended to be used for non visible other native callees like IC callee.

* JSTests/wasm/function-tests/nameSection.js:
* JSTests/wasm/function-tests/stack-trace.js:
* JSTests/wasm/function-tests/trap-after-cross-instance-call.js:
* JSTests/wasm/function-tests/trap-load-2.js:
* JSTests/wasm/function-tests/trap-load-shared.js:
* JSTests/wasm/function-tests/trap-load.js:
* JSTests/wasm/stress/simple-inline-stacktrace-with-catch-2.js:
(let.readMem.new.Int32Array.wasm_instance.exports.mem.buffer.const.iterCount.9.verifyStack):
(readMem.0.0):
* JSTests/wasm/stress/simple-inline-stacktrace-with-catch.js:
(let.readMem.new.Int32Array.wasm_instance.exports.mem.buffer.const.iterCount.9.verifyStack):
(readMem.0.0):
* JSTests/wasm/stress/simple-inline-stacktrace.js:
(i.catch):
* Source/JavaScriptCore/interpreter/StackVisitor.cpp:
(JSC::StackVisitor::Frame::isImplementationVisibilityPrivate const):
* Source/JavaScriptCore/wasm/WasmCallee.cpp:
(JSC::Wasm::Callee::Callee):
* Source/JavaScriptCore/wasm/WasmCallee.h:
(JSC::Wasm::Callee::implementationVisibility const):

Canonical link: https://commits.webkit.org/262191@main




More information about the webkit-changes mailing list