[webkit-changes] [WebKit/WebKit] 677a38: [RemoteInspector][Socket] change RunLoop::cycle() ...

Haruhisa SHIN noreply at github.com
Mon Mar 27 18:10:20 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 677a38a7599f3dbe1e53daf03e96658ef6a6101a
      https://github.com/WebKit/WebKit/commit/677a38a7599f3dbe1e53daf03e96658ef6a6101a
  Author: Haruhisa SHIN <haruhisa.shin at open-tec.co.jp>
  Date:   2023-03-27 (Mon, 27 Mar 2023)

  Changed paths:
    M Source/WTF/wtf/win/RunLoopWin.cpp

  Log Message:
  -----------
  [RemoteInspector][Socket] change RunLoop::cycle() to non-blocking
https://bugs.webkit.org/show_bug.cgi?id=254396

Reviewed by Kimmo Kinnunen.

RemoteInspector's thread for receiving socket data was processing messages via non-blocking RunLoop::iterate().
The RunLoop::cycle() that was replaced by iterate() by 254382 at main was blocking, so it could no longer receive socket data.

The implementation of RunLoopGeneric and RunLoopGlib are non-blocking.
This patch changes cycle() of RunLoopWin to non-blocking as well.

* Source/WTF/wtf/win/RunLoopWin.cpp:
(WTF::RunLoop::cycle):

Canonical link: https://commits.webkit.org/262188@main




More information about the webkit-changes mailing list