[webkit-changes] [WebKit/WebKit] 7e769b: Versioning.
Russell Epstein
noreply at github.com
Mon Mar 27 14:55:10 PDT 2023
Branch: refs/heads/safari-7615.1.26.10-branch
Home: https://github.com/WebKit/WebKit
Commit: 7e769b6c0701219f51050833e6824b3c34993d8f
https://github.com/WebKit/WebKit/commit/7e769b6c0701219f51050833e6824b3c34993d8f
Author: Russell Epstein <repstein at apple.com>
Date: 2023-03-02 (Thu, 02 Mar 2023)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7615.1.26.10.1
Canonical link: https://commits.webkit.org/259548.351@safari-7615.1.26.10-branch
Commit: 4de34ca1c1a3b360902d539767513ac65b641c17
https://github.com/WebKit/WebKit/commit/4de34ca1c1a3b360902d539767513ac65b641c17
Author: Myles C. Maxfield <mmaxfield at apple.com>
Date: 2023-03-02 (Thu, 02 Mar 2023)
Changed paths:
M LayoutTests/platform/mac-wk1/editing/mac/attributed-string/font-style-variant-effect-expected.txt
Log Message:
-----------
Cherry-pick 5f719dd2df1a. rdar://problem/105997287
Revert 260295 at main because it was unnecessary
https://bugs.webkit.org/show_bug.cgi?id=253033
rdar://105997287
Unreviewed gardening.
1. https://commits.webkit.org/260130@main caused the test to fail
2. https://commits.webkit.org/260295@main updated the test's expected results (which is what this radar was originally about)
3. https://commits.webkit.org/260447@main caused the test to fail the opposite way
So https://commits.webkit.org/260447@main fixed the bug, and https://commits.webkit.org/260295@main was wrong.
* LayoutTests/platform/mac-wk1/editing/mac/attributed-string/font-style-variant-effect-expected.txt:
Canonical link: https://commits.webkit.org/260918@main
Canonical link: https://commits.webkit.org/259548.352@safari-7615.1.26.10-branch
Commit: 0abaf27c0bfdd990a103bd28e98297f9889a2833
https://github.com/WebKit/WebKit/commit/0abaf27c0bfdd990a103bd28e98297f9889a2833
Author: Jer Noble <jer.noble at apple.com>
Date: 2023-03-02 (Thu, 02 Mar 2023)
Changed paths:
M Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm
Log Message:
-----------
Cherry-pick 96230945f879. rdar://problem/94878533
CRASH: GPUP at -[WebCoreNSURLSessionDataTask _cancel]
https://bugs.webkit.org/show_bug.cgi?id=253044
rdar://94878533
Reviewed by Eric Carlson.
-[WebCoreNSURLSessionDataTask session] currently converts a WeakObjC pointer (safely) into
a RetainPtr, then returns a raw pointer from that RetainPtr. The RetainPtr is destroyed after
returning, which reduces the retain count. It is then stored into a RetainPtr again by the
caller inside -_cancel;
Meanwhile, on another thread, the WebCoreNSURLSession can be released by the system, leaving
an opportunity to release the WebCoreNSURLSession and reduce it's retain count to zero in
between the two RetainPtr calls on the main thread, leading to the client retaining a dealloc'd
object.
Instead, -session should return an autorelease()'d pointer, thereby ensuring the session is
retained long enough for the client to retain it. This will increase retain-count churn, but
will also guarantee the object cannot be destroyed on a background thread while it's still
being used on the main thread.
* Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSessionDataTask session]):
Canonical link: https://commits.webkit.org/260941@main
Canonical link: https://commits.webkit.org/259548.353@safari-7615.1.26.10-branch
Commit: c2b816c5b664c706b29a3299e5b21b8ac5aecc87
https://github.com/WebKit/WebKit/commit/c2b816c5b664c706b29a3299e5b21b8ac5aecc87
Author: Chris Dumez <cdumez at apple.com>
Date: 2023-03-02 (Thu, 02 Mar 2023)
Changed paths:
A LayoutTests/fast/screen-orientation/natural-orientation-expected.txt
A LayoutTests/fast/screen-orientation/natural-orientation.html
M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/orientation-reading-expected.txt
A LayoutTests/platform/ios/fast/screen-orientation/natural-orientation-expected.txt
M Source/WebCore/page/ScreenOrientation.cpp
M Source/WebCore/page/ScreenOrientationType.h
M Source/WebCore/platform/ScreenOrientationProvider.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebScreenOrientationManager.cpp
Log Message:
-----------
Cherry-pick 541ca5a79560. rdar://problem/105891522
Regression(255659 at main) Unable to log into twitch.tv
https://bugs.webkit.org/show_bug.cgi?id=253026
rdar://105891522
Reviewed by Wenson Hsieh and Darin Adler.
The Twitch.tv login was failing because `screen.orientation` was returning
"portrait-primary" on macOS. The natural/default orientation on desktop should
be "landscape-primary" so this was confusing Twitch.
Also update our `screen.angle` logic to take into account the natural
orientation based on:
- https://w3c.github.io/screen-orientation/#dfn-screen-orientation-values-table
I have verified that Chrome on macOS returns "landscape-primary" for the type
and 0 for the angle. Our behavior is now aligned.
* LayoutTests/fast/screen-orientation/natural-orientation-expected.txt: Added.
* LayoutTests/fast/screen-orientation/natural-orientation.html: Added.
* LayoutTests/platform/ios/screen-orientation/natural-orientation-expected.txt: Added.
* Source/WebCore/page/ScreenOrientation.cpp:
(WebCore::ScreenOrientation::lock):
* Source/WebCore/page/ScreenOrientationType.h:
(WebCore::naturalScreenOrientationType):
* Source/WebCore/platform/ScreenOrientationProvider.cpp:
(WebCore::ScreenOrientationProvider::currentOrientation):
* Source/WebKit/WebProcess/WebCoreSupport/WebScreenOrientationManager.cpp:
(WebKit::WebScreenOrientationManager::currentOrientation):
Canonical link: https://commits.webkit.org/260944@main
Canonical link: https://commits.webkit.org/259548.354@safari-7615.1.26.10-branch
Commit: 6c2661ca8564861c64e6af929c454faaa3e7140a
https://github.com/WebKit/WebKit/commit/6c2661ca8564861c64e6af929c454faaa3e7140a
Author: Sammy Gill <sammy.gill at apple.com>
Date: 2023-03-02 (Thu, 02 Mar 2023)
Changed paths:
M LayoutTests/TestExpectations
A LayoutTests/fast/inline/legacy-margin-trim/block-container-float-nested-inside-nested-inline-expected.html
A LayoutTests/fast/inline/legacy-margin-trim/block-container-float-nested-inside-nested-inline.html
A LayoutTests/fast/inline/legacy-margin-trim/block-container-floats-adjacent-to-containing-block-should-be-trimmed-only-expected.html
A LayoutTests/fast/inline/legacy-margin-trim/block-container-floats-adjacent-to-containing-block-should-be-trimmed-only.html
A LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-left-positioned-float-intersecting-other-float-to-fit-expected.html
A LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-left-positioned-float-intersecting-other-float-to-fit.html
A LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-left-positioned-float-overconstraining-line-box-to-fit-expected.html
A LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-left-positioned-float-overconstraining-line-box-to-fit-rtl-expected.html
A LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-left-positioned-float-overconstraining-line-box-to-fit-rtl.html
A LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-left-positioned-float-overconstraining-line-box-to-fit-vert-lr-expected.html
A LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-left-positioned-float-overconstraining-line-box-to-fit-vert-lr.html
A LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-left-positioned-float-overconstraining-line-box-to-fit.html
A LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-orthogonal-float-overconstraining-line-box-to-fit-expected.html
A LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-orthogonal-float-overconstraining-line-box-to-fit.html
A LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-right-positioned-float-intersecting-other-float-to-fit-expected.html
A LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-right-positioned-float-intersecting-other-float-to-fit.html
A LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-right-positioned-float-overconstraining-line-box-to-fit-expected.html
A LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-right-positioned-float-overconstraining-line-box-to-fit-rtl-expected.html
A LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-right-positioned-float-overconstraining-line-box-to-fit-rtl.html
A LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-right-positioned-float-overconstraining-line-box-to-fit-vert-lr-expected.html
A LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-right-positioned-float-overconstraining-line-box-to-fit-vert-lr.html
A LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-right-positioned-float-overconstraining-line-box-to-fit.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-nested-inside-nested-inline-expected.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-nested-inside-nested-inline.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-floats-adjacent-to-containing-block-should-be-trimmed-only-expected.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-floats-adjacent-to-containing-block-should-be-trimmed-only.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-left-positioned-float-intersecting-other-float-to-fit-expected.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-left-positioned-float-intersecting-other-float-to-fit.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-left-positioned-float-overconstraining-line-box-to-fit-expected.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-left-positioned-float-overconstraining-line-box-to-fit-rtl-expected.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-left-positioned-float-overconstraining-line-box-to-fit-rtl.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-left-positioned-float-overconstraining-line-box-to-fit-vert-lr-expected.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-left-positioned-float-overconstraining-line-box-to-fit-vert-lr.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-left-positioned-float-overconstraining-line-box-to-fit.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-orthogonal-float-overconstraining-line-box-to-fit-expected.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-orthogonal-float-overconstraining-line-box-to-fit.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-right-positioned-float-intersecting-other-float-to-fit-expected.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-right-positioned-float-intersecting-other-float-to-fit.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-right-positioned-float-overconstraining-line-box-to-fit-expected.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-right-positioned-float-overconstraining-line-box-to-fit-rtl-expected.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-right-positioned-float-overconstraining-line-box-to-fit-rtl.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-right-positioned-float-overconstraining-line-box-to-fit-vert-lr-expected.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-right-positioned-float-overconstraining-line-box-to-fit-vert-lr.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-right-positioned-float-overconstraining-line-box-to-fit.html
M Source/WebCore/rendering/line/BreakingContext.h
Log Message:
-----------
Cherry-pick bad6e12c6625. rdar://problem/105984917
Trim margins for overconstraining floats that are adjacent to the containing block inner without clear and other intrusive floats
https://bugs.webkit.org/show_bug.cgi?id=253008
rdar://105984917
Reviewed by Alan Baradlay.
When going through float layout and determining their position within a
containing block we check to see if they would overconstrain any lines
boxes or would intersect with any other floats at that candidate
position. If they would, we would hold off on positioning them until we
finish inline layout with the current line. However, with margin-trim
it is possible that these floats would fit at these positions with their
margins trimmed.
In order to determine whether we can trim such a margin, the following
must be true for the float:
1.) The float's candidate position is adjacent to the containing block's
inner edge
2.) margin-trim is set for that edge (e.g. margin-trim:
inline/inline-start for a left positioned float)
3.) The float overconstrains a line box or intersects with another float
at that vertical position but would not overconstrain a line
box/intersect a float if that margin were trimmed
In these scenarios we can trim the appropriate margin for the float and
place it at that vertical position.
container {
display: block;
border: 1px solid black;
inline-size: 100px;
font-family: monospace;
font-size: 10px;
margin-trim: inline;
}
item {
display: block;
inline-size: 25px;
block-size: 80px;
background-color: green;
margin-inline-end: 80px;
float: right;
}
</style>
<container>
<span>The text</span>
<item></item>
<span>should wrap alongside the float to the right</span>
</container>
Without margin-trim the float would overconstrain the first line box
and would not get placed at the same vertical position. However, since
margin-trim is specified, resulting box would fit at that position, and
it would get placed against the containing block's inner edge,
then we can trim its margins and place it there.
container {
display: block;
inline-size: 100px;
font-family: monospace;
font-size: 10px;
margin-trim: inline;
}
item {
display: block;
inline-size: 50px;
block-size: 100px;
background-color: green;
}
.float-right {
float: right;
margin-inline-end: 80px;
}
.float-left {
float: left;
}
</style>
<container>
<span>Test passes if there is a filled green square below.</span></br>
<item class="float-left"></item>
<item class="float-right"></item>
</container>
Similarly, after placing the first float we would not normally be able
to position the second one since the margin would result in it
intersecting with the other one. However due to the same conditions
in the first example we can trim the inline-end margin and place it at
the same vertical position as the other float.
* LayoutTests/TestExpectations:
* LayoutTests/fast/inline/legacy-margin-trim/block-container-float-nested-inside-nested-inline-expected.html: Added.
* LayoutTests/fast/inline/legacy-margin-trim/block-container-float-nested-inside-nested-inline.html: Added.
* LayoutTests/fast/inline/legacy-margin-trim/block-container-floats-adjacent-to-containing-block-should-be-trimmed-only-expected.html: Added.
* LayoutTests/fast/inline/legacy-margin-trim/block-container-floats-adjacent-to-containing-block-should-be-trimmed-only.html: Added.
* LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-left-positioned-float-intersecting-other-float-to-fit-expected.html: Added.
* LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-left-positioned-float-intersecting-other-float-to-fit.html: Added.
* LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-left-positioned-float-overconstraining-line-box-to-fit-expected.html: Added.
* LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-left-positioned-float-overconstraining-line-box-to-fit-rtl-expected.html: Added.
* LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-left-positioned-float-overconstraining-line-box-to-fit-rtl.html: Added.
* LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-left-positioned-float-overconstraining-line-box-to-fit-vert-lr-expected.html: Added.
* LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-left-positioned-float-overconstraining-line-box-to-fit-vert-lr.html: Added.
* LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-left-positioned-float-overconstraining-line-box-to-fit.html: Added.
* LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-orthogonal-float-overconstraining-line-box-to-fit-expected.html: Added.
* LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-orthogonal-float-overconstraining-line-box-to-fit.html: Added.
* LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-right-positioned-float-intersecting-other-float-to-fit-expected.html: Added.
* LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-right-positioned-float-intersecting-other-float-to-fit.html: Added.
* LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-right-positioned-float-overconstraining-line-box-to-fit-expected.html: Added.
* LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-right-positioned-float-overconstraining-line-box-to-fit-rtl-expected.html: Added.
* LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-right-positioned-float-overconstraining-line-box-to-fit-rtl.html: Added.
* LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-right-positioned-float-overconstraining-line-box-to-fit-vert-lr-expected.html: Added.
* LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-right-positioned-float-overconstraining-line-box-to-fit-vert-lr.html: Added.
* LayoutTests/fast/inline/legacy-margin-trim/block-container-trimmed-margin-allows-right-positioned-float-overconstraining-line-box-to-fit.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-nested-inside-nested-inline-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-float-nested-inside-nested-inline.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-floats-adjacent-to-containing-block-should-be-trimmed-only-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-floats-adjacent-to-containing-block-should-be-trimmed-only.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-left-positioned-float-intersecting-other-float-to-fit-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-left-positioned-float-intersecting-other-float-to-fit.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-left-positioned-float-overconstraining-line-box-to-fit-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-left-positioned-float-overconstraining-line-box-to-fit-rtl-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-left-positioned-float-overconstraining-line-box-to-fit-rtl.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-left-positioned-float-overconstraining-line-box-to-fit-vert-lr-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-left-positioned-float-overconstraining-line-box-to-fit-vert-lr.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-left-positioned-float-overconstraining-line-box-to-fit.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-orthogonal-float-overconstraining-line-box-to-fit-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-orthogonal-float-overconstraining-line-box-to-fit.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-right-positioned-float-intersecting-other-float-to-fit-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-right-positioned-float-intersecting-other-float-to-fit.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-right-positioned-float-overconstraining-line-box-to-fit-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-right-positioned-float-overconstraining-line-box-to-fit-rtl-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-right-positioned-float-overconstraining-line-box-to-fit-rtl.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-right-positioned-float-overconstraining-line-box-to-fit-vert-lr-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-right-positioned-float-overconstraining-line-box-to-fit-vert-lr.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/block-container-trimmed-margin-allows-right-positioned-float-overconstraining-line-box-to-fit.html: Added.
* Source/WebCore/rendering/line/BreakingContext.h:
(WebCore::BreakingContext::handleFloat):
Canonical link: https://commits.webkit.org/260950@main
Canonical link: https://commits.webkit.org/259548.355@safari-7615.1.26.10-branch
Commit: c80811dc771ce8e7573dec3d9b2fd2f37ee5b255
https://github.com/WebKit/WebKit/commit/c80811dc771ce8e7573dec3d9b2fd2f37ee5b255
Author: Tim Nguyen <ntim at apple.com>
Date: 2023-03-02 (Thu, 02 Mar 2023)
Changed paths:
A LayoutTests/imported/w3c/web-platform-tests/fullscreen/model/move-fullscreen-element-expected.txt
A LayoutTests/imported/w3c/web-platform-tests/fullscreen/model/move-fullscreen-element.html
M Source/WebCore/dom/FullscreenManager.cpp
Log Message:
-----------
Cherry-pick d8b353380562. rdar://problem/105713729
REGRESSION(257542 at main): Video is misaligned on YouTube site's PiP player after transitioning from full screen
https://bugs.webkit.org/show_bug.cgi?id=253121
rdar://105713729
Reviewed by Ryosuke Niwa.
There is a bug with the fullscreen spec that leaves a dangling fullscreen flag when moving elements: https://github.com/whatwg/fullscreen/issues/217
This causes fullscreen styles to unintentionally apply on the YouTube site even though the player element which has moved in the DOM tree, has exited
fullscreen.
To fix this, we follow Chromium's pattern of running an extra "unfullscreen element" step in the synchronous exit fullscreen steps when the element to
be exited is disconnected.
* LayoutTests/imported/w3c/web-platform-tests/fullscreen/model/move-fullscreen-element-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/fullscreen/model/move-fullscreen-element.html: Added.
* Source/WebCore/dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::exitFullscreen):
Canonical link: https://commits.webkit.org/260985@main
Canonical link: https://commits.webkit.org/259548.356@safari-7615.1.26.10-branch
Commit: 3965f8fc6e20169ca5fe8af0c6e0252f87e47e0f
https://github.com/WebKit/WebKit/commit/3965f8fc6e20169ca5fe8af0c6e0252f87e47e0f
Author: Aditya Keerthi <akeerthi at apple.com>
Date: 2023-03-02 (Thu, 02 Mar 2023)
Changed paths:
M Source/WebKit/UIProcess/ios/WKPDFView.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm
Log Message:
-----------
Cherry-pick ad5c950167f1. rdar://problem/105784161
REGRESSION (259655 at main): [iOS] Crash when opening a PDF after searching for text in a webpage
https://bugs.webkit.org/show_bug.cgi?id=253194
rdar://105784161
Reviewed by Wenson Hsieh, Megan Gardner and Tim Horton.
259655 at main fixed find-in-PDF behavior by ensuring the `UIFindSession`'s
"searchable object" is always up-to-date.
When switching from a webpage to a PDF, WebKit switches the type of the
searchable object from `WKContentView` to `WKPDFView`. UIKit is not robust
against searchable object modification, as they cache the existence of
optional protocol methods and do not update the result when the object changes.
Consequently, optional protocol methods are called unconditionally on
`WKPDFView`, simply because `WKContentView` implements them.
Ideally, WebKit would recreate the `UIFindSession` itself when the searchable
object changes. However, this is not possible with existing API/SPI.
To fix, implement "optional" protocol methods that UIKit may end up calling
when searching for text. This prevents crashing due to unrecognized selectors.
* Source/WebKit/UIProcess/ios/WKPDFView.mm:
(-[WKPDFView supportsTextReplacement]):
(-[WKPDFView scrollRangeToVisible:inDocument:]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
(TEST):
Add a regression test that opens and closes the find panel on web content, loads
a PDF, and then attempts to open and close the find panel on the PDF content.
The test crashes without this patch.
Canonical link: https://commits.webkit.org/261071@main
Canonical link: https://commits.webkit.org/259548.357@safari-7615.1.26.10-branch
Commit: 819a992a3a44a113bc421b34bc3063fef8997402
https://github.com/WebKit/WebKit/commit/819a992a3a44a113bc421b34bc3063fef8997402
Author: Antti Koivisto <antti at apple.com>
Date: 2023-03-02 (Thu, 02 Mar 2023)
Changed paths:
M Source/WebCore/style/AttributeChangeInvalidation.cpp
Log Message:
-----------
Cherry-pick 2c5baee03fa2. rdar://problem/105628059
nullptr crash in WebCore::SelectorChecker::attributeSelectorMatches
https://bugs.webkit.org/show_bug.cgi?id=253067
rdar://105628059
Reviewed by Geoffrey Garen and Alan Baradlay.
Speculative fix.
* Source/WebCore/style/AttributeChangeInvalidation.cpp:
(WebCore::Style::AttributeChangeInvalidation::invalidateStyle):
Check that we actually have an attribute selector.
Canonical link: https://commits.webkit.org/261076@main
Canonical link: https://commits.webkit.org/259548.358@safari-7615.1.26.10-branch
Commit: 64194a819a7894057fb7c7470a7670ce9b1dc48d
https://github.com/WebKit/WebKit/commit/64194a819a7894057fb7c7470a7670ce9b1dc48d
Author: Brandon Stewart <brandonstewart at apple.com>
Date: 2023-03-02 (Thu, 02 Mar 2023)
Changed paths:
M Source/WebCore/Modules/compression/DecompressionStreamDecoder.cpp
M Source/WebCore/Modules/compression/DecompressionStreamDecoder.h
Log Message:
-----------
Cherry-pick fe58e5cd0281. rdar://problem/106003684
Disable Apple Compression API in Compression Streams
https://bugs.webkit.org/show_bug.cgi?id=253042
Reviewed by Brent Fulgham.
Disable Compression API for Compression Streams right now as it is causing issues
on web sites.
* Source/WebCore/Modules/compression/DecompressionStreamDecoder.cpp:
(WebCore::DecompressionStreamDecoder::decompress):
* Source/WebCore/Modules/compression/DecompressionStreamDecoder.h:
(WebCore::DecompressionStreamDecoder::DecompressionStreamDecoder):
Canonical link: https://commits.webkit.org/260923@main
Canonical link: https://commits.webkit.org/259548.359@safari-7615.1.26.10-branch
Commit: c72565fcfd643a1ea4ce5625a05cb498d2574877
https://github.com/WebKit/WebKit/commit/c72565fcfd643a1ea4ce5625a05cb498d2574877
Author: Youenn Fablet <youennf at gmail.com>
Date: 2023-03-02 (Thu, 02 Mar 2023)
Changed paths:
M Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp
M Source/WebCore/platform/mediastream/RealtimeMediaSource.h
M Source/WebCore/platform/mediastream/RealtimeVideoSource.h
M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h
M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm
Log Message:
-----------
Cherry-pick c9e35ddc3cab. rdar://problem/105677398
REGRESSION (iOS 16.4 Public Beta) getUserMedia ignores facingMode constraint
https://bugs.webkit.org/show_bug.cgi?id=252560
rdar://problem/105677398
Reviewed by Eric Carlson.
We added a way to favor some back cameras (those that have a great focal range) against other back cameras.
We did this by increasing the facingMode fitness distance for the telephoto back cameras.
The base fitness distance for user/environment facingMode constraint is either 0 (match) or 1 (no match).
When facingMode is environement, the front camera will have a base fitness distance of 1 and a final fitness distance of 1.
The back camera will have a base fitness distance of 0 and a final fitness distance of 0 + the fitness distance increase.
The fitness distance increase is either 0, 1, 2...
The issue is that RealtimeMediaSource::supportsConstraints computes the fitness score by checking whether distance is 0 or something else.
If distance is 0, the score is 32 otherwise it is 1.
This ensures that facingMode has a big weight on the global fitness score.
We now apply facingModeFitnessDistanceAdjustment directly to the global fitness score.
This requires having good devices with a high value.
Renaming facingModeFitnessDistanceAdjustment to facingModeFitnessScoreAdjustment for that reason.
* Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:
(WebCore::RealtimeMediaSource::fitnessDistance):
(WebCore::RealtimeMediaSource::supportsConstraints):
* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::facingModeFitnessDistanceAdjustment const):
Canonical link: https://commits.webkit.org/260953@main
Canonical link: https://commits.webkit.org/259548.360@safari-7615.1.26.10-branch
Commit: f1e42314af476b08001cbe278889a57b6df0a4c7
https://github.com/WebKit/WebKit/commit/f1e42314af476b08001cbe278889a57b6df0a4c7
Author: Dan Robson <dan_robson at apple.com>
Date: 2023-03-03 (Fri, 03 Mar 2023)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7615.1.26.13.2
Identifier: 259548.361 at safari-7615.1.26.10-branch
Commit: 9e005db14ee9bbe2d37fa7ef14a6d47799827052
https://github.com/WebKit/WebKit/commit/9e005db14ee9bbe2d37fa7ef14a6d47799827052
Author: Dan Robson <dan_robson at apple.com>
Date: 2023-03-03 (Fri, 03 Mar 2023)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7615.1.26.10.2
Identifier: 259548.362 at safari-7615.1.26.10-branch
Commit: 8de2718f6e772fe2aa0f172521e55ea2510f4ca7
https://github.com/WebKit/WebKit/commit/8de2718f6e772fe2aa0f172521e55ea2510f4ca7
Author: Matt Woodrow <mattwoodrow at apple.com>
Date: 2023-03-03 (Fri, 03 Mar 2023)
Changed paths:
M Source/WebCore/html/OffscreenCanvas.cpp
Log Message:
-----------
Cherry-pick 630b1e2aa50f. rdar://problem/105684718
Disable main-thread WebGL in OffscreenCanvas.
https://bugs.webkit.org/show_bug.cgi?id=253267
<rdar://105684718>
Reviewed by Simon Fraser.
* Source/WebCore/html/OffscreenCanvas.cpp:
(WebCore::shouldEnableWebGL):
Canonical link: https://commits.webkit.org/259548.355@safari-7615-branch
Commit: 4305cba77dac10a33f1b7ff6c64cf584dab610d9
https://github.com/WebKit/WebKit/commit/4305cba77dac10a33f1b7ff6c64cf584dab610d9
Author: Chris Dumez <cdumez at apple.com>
Date: 2023-03-03 (Fri, 03 Mar 2023)
Changed paths:
M Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp
M Source/WebCore/loader/cache/CachedResourceLoader.cpp
M Source/WebCore/page/Quirks.cpp
M Source/WebCore/page/Quirks.h
Log Message:
-----------
Cherry-pick eb5cfc861737. rdar://problem/104818312
Regression(256456 at main) Express checkout is broken on victoriassecret.com
https://bugs.webkit.org/show_bug.cgi?id=253265
rdar://104818312
Reviewed by Brent Fulgham and Youenn Fablet.
Temporarily disable the Fetch Metadata feature on victoriassecret.com since it
breaks express checkout and while we're investigate the root cause.
* Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp:
(WebCore::ThreadableWebSocketChannel::webSocketConnectRequest):
* Source/WebCore/loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::updateRequestAfterRedirection):
(WebCore::CachedResourceLoader::updateHTTPRequestHeaders):
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldDisableFetchMetadata const):
* Source/WebCore/page/Quirks.h:
Canonical link: https://commits.webkit.org/261141@main
Commit: 09db7268bee703c3509b32b9cd5fa18f1b192ce6
https://github.com/WebKit/WebKit/commit/09db7268bee703c3509b32b9cd5fa18f1b192ce6
Author: Alex Christensen <achristensen at apple.com>
Date: 2023-03-03 (Fri, 03 Mar 2023)
Changed paths:
M Source/WebKit/NetworkProcess/NetworkProcess.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm
Log Message:
-----------
Cherry-pick 6dd3a73e5aa2. rdar://problem/105201326
REGRESSION(255420 at main) Embed-loading PDFs from newly opened about:blank terminates web process
https://bugs.webkit.org/show_bug.cgi?id=253285
rdar://105201326
Reviewed by J Pascoe.
In 255420 at main I introduced checks in the network process to make sure that firstPartyForCookies
is an allowed domain for that process. There are a few places in WebKit where we still have
about:blank or a null firstPartyForCookies, which is fine most of the time because
ResourceRequest::allowCookies is false so it doesn't matter that there's no firstPartyForCookies.
Sometimes, though, we have a piece of code that loads without a firstPartyForCookies and allows
cookies. This is an existing bug and should probably be fixed, but it is not catastrophic
because the result is that no cookie access is given. However, with 255420 at main it became catastrophic
because we terminate the web content process, which I'm told is undesirable when a user is trying to do
something like download a PDF. This change makes it no longer terminate the web content process.
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::allowsFirstPartyForCookies):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:
(TEST):
Canonical link: https://commits.webkit.org/261142@main
Commit: 0713fc186a5dc2d58b907de64e661ad261832d8b
https://github.com/WebKit/WebKit/commit/0713fc186a5dc2d58b907de64e661ad261832d8b
Author: Sihui Liu <sihui_liu at apple.com>
Date: 2023-03-03 (Fri, 03 Mar 2023)
Changed paths:
M Source/WebKit/NetworkProcess/storage/CacheStorageCache.cpp
M Source/WebKit/NetworkProcess/storage/CacheStorageCache.h
Log Message:
-----------
Cherry-pick 5c2607837be6. rdar://problem/105122133
Add assertions in CacheStorageCache to help debug threading issues
https://bugs.webkit.org/show_bug.cgi?id=253223
rdar://106124999
Reviewed by Chris Dumez.
rdar://105122133 indicates CacheStorageCache may have threading issues (e.g. record url may become AtomString at some
point), so adding some assertion to help debug that.
This patch also make an isolated copy for record url before passing it to CacheStorageCache.
* Source/WebKit/NetworkProcess/storage/CacheStorageCache.cpp:
(WebKit::computeKeyURL):
(WebKit::CacheStorageCache::CacheStorageCache):
(WebKit::CacheStorageCache::getSize):
(WebKit::CacheStorageCache::open):
(WebKit::CacheStorageCache::retrieveRecords):
(WebKit::CacheStorageCache::removeRecords):
(WebKit::CacheStorageCache::findExistingRecord):
(WebKit::CacheStorageCache::putRecords):
(WebKit::CacheStorageCache::putRecordsAfterQuotaCheck):
(WebKit::CacheStorageCache::putRecordsInStore):
(WebKit::CacheStorageCache::removeAllRecords):
(WebKit::CacheStorageCache::close):
* Source/WebKit/NetworkProcess/storage/CacheStorageCache.h:
(WebKit::CacheStorageCache::assertIsOnCorrectQueue):
Canonical link: https://commits.webkit.org/261147@main
Commit: 649a8de61dc0d0646a4d142a39ed6cc436ac892e
https://github.com/WebKit/WebKit/commit/649a8de61dc0d0646a4d142a39ed6cc436ac892e
Author: Russell Epstein <repstein at apple.com>
Date: 2023-03-03 (Fri, 03 Mar 2023)
Changed paths:
M LayoutTests/TestExpectations
A LayoutTests/fast/editing/ruby-with-edited-text-crash-expected.txt
A LayoutTests/fast/editing/ruby-with-edited-text-crash.html
M Source/WebCore/rendering/RenderBlock.cpp
Log Message:
-----------
Cherry-pick 6f9b18dfa549. rdar://problem/105848359
Cherry-pick 261063 at main (02bb8ae9d573). rdar://problem/105848359
Make sure child is a RenderElement before trying to pass it into shouldChildInlineMarginContributeToContainerIntrinsicSize in RenderBlock::computeBlockPreferredLogicalWidths
https://bugs.webkit.org/show_bug.cgi?id=253165
rdar://105848359
Reviewed by Alan Baradlay.
We should not be assuming that child is always doing to be a
RenderElement in this method. It can sometimes be a RenderText (like
in the attached test case), which will cause a nullptr dereference.
Instead, we should check the result of the dynamicDowncast before
passing it into shouldChildInlineMarginContributeToContainerIntrinsicSize.
The only other change is that we use the default constructor for
startMarginLength and endMarginLength. This should be ok even if we do
not enter the code guarded by the if statement because the isFixed()
call will return false and not impact the margins.
* LayoutTests/TestExpectations:
* LayoutTests/fast/editing/ruby-with-edited-text-crash-expected.txt: Added.
* LayoutTests/fast/editing/ruby-with-edited-text-crash.html: Added.
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths const):
Canonical link: https://commits.webkit.org/261063@main
Canonical link: https://commits.webkit.org/259548.371@safari-7615-branch
Commit: 524ebd3095c7067e474e19251e2c60f324043921
https://github.com/WebKit/WebKit/commit/524ebd3095c7067e474e19251e2c60f324043921
Author: Russell Epstein <repstein at apple.com>
Date: 2023-03-03 (Fri, 03 Mar 2023)
Changed paths:
M Source/WebKit/NetworkProcess/NetworkProcess.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm
Log Message:
-----------
Revert "Cherry-pick 6dd3a73e5aa2. rdar://problem/105201326"
This reverts commit 09db7268bee703c3509b32b9cd5fa18f1b192ce6.
Canonical link: https://commits.webkit.org/259548.368@safari-7615.1.26.10-branch
Commit: 3ce83aaeff7ff0c6ee9d2ad8dce2a0a139241b5e
https://github.com/WebKit/WebKit/commit/3ce83aaeff7ff0c6ee9d2ad8dce2a0a139241b5e
Author: Dan Robson <dan_robson at apple.com>
Date: 2023-03-09 (Thu, 09 Mar 2023)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
Canonical link: https://commits.webkit.org/259548.369@safari-7615.1.26.10-branch
Commit: 83ac5215949115da9fc7b944ba6882121c9e684c
https://github.com/WebKit/WebKit/commit/83ac5215949115da9fc7b944ba6882121c9e684c
Author: Chris Dumez <cdumez at apple.com>
Date: 2023-03-09 (Thu, 09 Mar 2023)
Changed paths:
M Source/WebKit/UIProcess/WebFrameProxy.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm
Log Message:
-----------
Cherry-pick e3cbd8226ecc. rdar://problem/106316283
Regression(258149 at main) 1Password autofill is broken on nytimes.com
https://bugs.webkit.org/show_bug.cgi?id=253576
rdar://106316283
Reviewed by Timothy Hatcher.
Before 258149 at main, the [WKWebView _frames:completionHander:] SPI was relying
on the WebProcess's FrameTree to return the state of the frames as a tree.
However, after the refactoring in 258149 at main, we do the tree traversal on
the UIProcess side and IPC each frame independently. To do this traversal,
we rely on WebFrameProxy::m_childFrames.
However, we have a bug where WebFrameProxy::m_childFrames could contain
subframes from previous pages that were previously visited in this view.
The reason for this is that the main frame (and thus the main WebFrameProxy)
gets reused on navigation. However, WebFrameProxy::m_childFrames is not getting
cleared whenever the frame navigates.
I initially tried to clear m_childFrames when a load gets committed in the
frame. However, this introduced crashes when restoring a back/forward cache
entry. The reason for this is that we currently don't notify the UIProcess
when restoring frames from the back/forward cache. As a result, m_childFrames
would not correctly get re-populated after restoring a back/forward cache
entry and it would lead to issues later on.
To make the fix as minimal and as safe as possible for the branch, I am opting
to update WebFrameProxy::getFrameInfo() to filter out frameData for frames
whose parentFrameID doesn't match the current frame's ID. This makes sure
that we only report about iframes that are currently in the frame tree, just
like we used to before 258149 at main.
In a follow-up, we should refactor this to make sure that m_childFrames is
an accurate and current representation of the frame tree, since we're going
to rely on it more and more for site isolation.
* Source/WebKit/UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didCommitLoad):
(WebKit::WebFrameProxy::didFailLoad):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/261429@main
Canonical link: https://commits.webkit.org/259548.370@safari-7615.1.26.10-branch
Commit: 1b3f3ed4e8cc7e88b1d25772e97a663df6c262ea
https://github.com/WebKit/WebKit/commit/1b3f3ed4e8cc7e88b1d25772e97a663df6c262ea
Author: Myah Cobbs <mcobbs at apple.com>
Date: 2023-03-10 (Fri, 10 Mar 2023)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
Canonical link: https://commits.webkit.org/259548.371@safari-7615.1.26.10-branch
Commit: 67062744d69e502d3803bb4143ad6be3c0413479
https://github.com/WebKit/WebKit/commit/67062744d69e502d3803bb4143ad6be3c0413479
Author: Dan Robson <dan_robson at apple.com>
Date: 2023-03-10 (Fri, 10 Mar 2023)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
Canonical link: https://commits.webkit.org/259548.372@safari-7615.1.26.10-branch
Commit: d36ef046252d731ef44697d1aff4c7fe1e1f0dca
https://github.com/WebKit/WebKit/commit/d36ef046252d731ef44697d1aff4c7fe1e1f0dca
Author: Kocsen Chung <kocsen_chung at apple.com>
Date: 2023-03-12 (Sun, 12 Mar 2023)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7615.1.26.10.4
Canonical link: https://commits.webkit.org/259548.373@safari-7615.1.26.10-branch
Commit: 20e654ed5476fc0e949ed370e2cea898b99fdc7f
https://github.com/WebKit/WebKit/commit/20e654ed5476fc0e949ed370e2cea898b99fdc7f
Author: Kocsen Chung <kocsen_chung at apple.com>
Date: 2023-03-12 (Sun, 12 Mar 2023)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Fix Versioning and remove the prefixing 7.
Canonical link: https://commits.webkit.org/259548.374@safari-7615.1.26.10-branch
Commit: b771183f5b8137066d1607a511c21627abf9388b
https://github.com/WebKit/WebKit/commit/b771183f5b8137066d1607a511c21627abf9388b
Author: Kocsen Chung <kocsen_chung at apple.com>
Date: 2023-03-12 (Sun, 12 Mar 2023)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7615.1.26.10.20
Canonical link: https://commits.webkit.org/259548.375@safari-7615.1.26.10-branch
Commit: b28f221275e80bf38ce15e980ab5f14ba2d07147
https://github.com/WebKit/WebKit/commit/b28f221275e80bf38ce15e980ab5f14ba2d07147
Author: Dan Robson <dan_robson at apple.com>
Date: 2023-03-13 (Mon, 13 Mar 2023)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
Canonical link: https://commits.webkit.org/259548.376@safari-7615.1.26.10-branch
Commit: fb2c529cf3f45553835ec4cda5ecd2140c03a3d7
https://github.com/WebKit/WebKit/commit/fb2c529cf3f45553835ec4cda5ecd2140c03a3d7
Author: Matt Woodrow <mattwoodrow at apple.com>
Date: 2023-03-13 (Mon, 13 Mar 2023)
Changed paths:
A LayoutTests/fast/canvas/offscreen-disabled-construct3-quirk-expected.txt
A LayoutTests/fast/canvas/offscreen-disabled-construct3-quirk.html
M Source/WebCore/bindings/js/JSDOMWindowCustom.cpp
Log Message:
-----------
Cherry-pick 0489426718c9. rdar://problem/106341361
OffscreenCanvas support without WebGL breaks Construct 3 content.
https://bugs.webkit.org/show_bug.cgi?id=253431
<rdar://106341361>
Reviewed by Chris Dumez.
Construct 3 is testing for the presence of OffscreenCanvas on the main thread, and then assumes
that a WebGL context will be able to be constructed from it.
We've only enabled Canvas2D on OffscreenCanvas currently, so detect this library and disable
OffscreenCanvas entirely.
* LayoutTests/fast/canvas/offscreen-disabled-construct3-quirk-expected.txt: Added.
* LayoutTests/fast/canvas/offscreen-disabled-construct3-quirk.html: Added.
* Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertySlot):
Canonical link: https://commits.webkit.org/259548.408@safari-7615-branch
Canonical link: https://commits.webkit.org/259548.377@safari-7615.1.26.10-branch
Commit: 7cd5006a69e686027047a27a7947527a4fd13bc8
https://github.com/WebKit/WebKit/commit/7cd5006a69e686027047a27a7947527a4fd13bc8
Author: Russell Epstein <repstein at apple.com>
Date: 2023-03-14 (Tue, 14 Mar 2023)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
Canonical link: https://commits.webkit.org/259548.378@safari-7615.1.26.10-branch
Commit: 5c5df3a902333d6bf3e54cd080795aa399036606
https://github.com/WebKit/WebKit/commit/5c5df3a902333d6bf3e54cd080795aa399036606
Author: Yusuke Suzuki <ysuzuki at apple.com>
Date: 2023-03-14 (Tue, 14 Mar 2023)
Changed paths:
R JSTests/microbenchmarks/map-iteration-and-array-destructuring.js
M JSTests/stress/destructuring-assignment-accepts-iterables.js
M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp
M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp
Log Message:
-----------
Cherry-pick 182d422f3194. rdar://problem/106578250
Revert [255681 at main] [JSC] Use fast iteration for array destructuring
rdar://106578250
Reviewed by Mark Lam.
Revert 255681 at main based on regression in rdar://106578250.
* JSTests/microbenchmarks/map-iteration-and-array-destructuring.js: Removed.
* JSTests/stress/destructuring-assignment-accepts-iterables.js:
(set shouldBe):
(set new):
* Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitEnumeration):
* Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:
(JSC::ArrayPatternNode::bindValue const):
Canonical link: https://commits.webkit.org/259548.413@safari-7615-branch
Canonical link: https://commits.webkit.org/259548.379@safari-7615.1.26.10-branch
Commit: 35ddeca25f7bc4ab5f0c9163cdcb57449bbd86c8
https://github.com/WebKit/WebKit/commit/35ddeca25f7bc4ab5f0c9163cdcb57449bbd86c8
Author: Russell Epstein <repstein at apple.com>
Date: 2023-03-22 (Wed, 22 Mar 2023)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7615.1.26.10.23
Canonical link: https://commits.webkit.org/259548.380@safari-7615.1.26.10-branch
Commit: 8fa069b8ad42669c9941fa252473013cd872dacc
https://github.com/WebKit/WebKit/commit/8fa069b8ad42669c9941fa252473013cd872dacc
Author: Russell Epstein <repstein at apple.com>
Date: 2023-03-22 (Wed, 22 Mar 2023)
Changed paths:
M Source/WebCore/html/HTMLMediaElement.cpp
Log Message:
-----------
Revert 80706457f5d9. rdar://problem/106963188
Canonical link: https://commits.webkit.org/259548.381@safari-7615.1.26.10-branch
Commit: 33e1840570404c3e666dd173779b48112721f3a6
https://github.com/WebKit/WebKit/commit/33e1840570404c3e666dd173779b48112721f3a6
Author: Russell Epstein <repstein at apple.com>
Date: 2023-03-22 (Wed, 22 Mar 2023)
Changed paths:
M LayoutTests/http/tests/media/autoplay-if-audio-is-playing-expected.txt
M LayoutTests/http/tests/media/autoplay-if-audio-is-playing.html
M LayoutTests/media/media-fullscreen-inline-expected.txt
M LayoutTests/media/media-fullscreen.js
M LayoutTests/media/playlist-inherits-user-gesture.html
M LayoutTests/media/restricted-audio-playback-with-multiple-settimeouts.html
M LayoutTests/platform/glib/media/media-fullscreen-inline-expected.txt
M LayoutTests/platform/glib/media/media-fullscreen-not-in-document-expected.txt
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/FullscreenManager.cpp
M Source/WebCore/html/HTMLMediaElement.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html
Log Message:
-----------
Revert 87bfcd1ee704. rdar://problem/106963188
Canonical link: https://commits.webkit.org/259548.382@safari-7615.1.26.10-branch
Compare: https://github.com/WebKit/WebKit/compare/7e769b6c0701%5E...33e184057040
More information about the webkit-changes
mailing list