[webkit-changes] [WebKit/WebKit] e988c7: Versioning.

Yusuke Suzuki noreply at github.com
Mon Mar 27 14:46:03 PDT 2023


  Branch: refs/heads/safari-7614.4.6.1-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: e988c7897e408d54f187b8f00594c88f82eae4f6
      https://github.com/WebKit/WebKit/commit/e988c7897e408d54f187b8f00594c88f82eae4f6
  Author: Myah Cobbs <mcobbs at apple.com>
  Date:   2022-12-21 (Wed, 21 Dec 2022)

  Changed paths:
    M Source/JavaScriptCore/Configurations/Version.xcconfig
    M Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
    M Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
    M Source/WebCore/Configurations/Version.xcconfig
    M Source/WebCore/PAL/Configurations/Version.xcconfig
    M Source/WebGPU/Configurations/Version.xcconfig
    M Source/WebInspectorUI/Configurations/Version.xcconfig
    M Source/WebKit/Configurations/Version.xcconfig
    M Source/WebKitLegacy/mac/Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7614.4.6.1.1

Canonical link: https://commits.webkit.org/252432.1008@safari-7614.4.6.1-branch


  Commit: 8c71be5bafe9bd7fb255f44640bf1545a9b65210
      https://github.com/WebKit/WebKit/commit/8c71be5bafe9bd7fb255f44640bf1545a9b65210
  Author: Sammy Gill <sammy.gill at apple.com>
  Date:   2022-12-21 (Wed, 21 Dec 2022)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-041-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-041.html
    M Source/WebCore/rendering/RenderBox.cpp

  Log Message:
  -----------
  Cherry-pick 28c5d0e82b0f. rdar://problem/103537352

    Ensure transferred max size is floored by transferred min size in RenderReplaced::computeIntrinsicSizesConstrainedByTransferredMinMaxSizes.
    https://bugs.webkit.org/show_bug.cgi?id=249617
    rdar://103537352

    Reviewed by Alan Baradlay.

    Addresses a regression introduced by a change inside of
    computeIntrinsicSizesConstrainedByTransferredMinMaxSizes. This method is
    supposed to compute the intrinsic size and ratio of a replaced element and
    also restrict that size if there are any transferred min/max constraints
    that are violated. This code was not checking if the transferred max size
    became smaller than the transferred min size. The max size is supposed to
    be floored by the min size in order to avoid this scenario.

    One situation in which this can happen is when we are computing the
    min/max logical height, the containing block has an available width
    of 0px, and the max-width specified is percentage based. When the call
    to computeLogicalWidthInFragmentUsing returns, it will return a value of
    0px when it resolves the percentage based max-width. Then, any specified
    value of min-width greater than 0px will cause this issue. The new code
    added addresses this issue by setting the max size to
    max(min size, max size).

    Ideally, we would be able to use RenderBox::constrainLogicalMinMaxSizesByAspectRatio,
    which has this logic for us, but my attempt to do this was causing issues
    when replaced elements were inside a flexbox.

    Spec reference: https://www.w3.org/TR/css-sizing-4/#aspect-ratio-size-transfers

    * LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-041-expected.html: Added.
    * LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-041.html: Added.
    * Source/WebCore/rendering/RenderBox.cpp:
    (WebCore::RenderBox::computeMinMaxLogicalWidthFromAspectRatio const):
    (WebCore::RenderBox::computeMinMaxLogicalHeightFromAspectRatio const):

    Canonical link: https://commits.webkit.org/258210@main

Canonical link: https://commits.webkit.org/252432.1009@safari-7614.4.6.1-branch


  Commit: ec0c11fcb801bdcfc95bd6caa1cb7545571fcecf
      https://github.com/WebKit/WebKit/commit/ec0c11fcb801bdcfc95bd6caa1cb7545571fcecf
  Author: Alan Coon <alancoon at apple.com>
  Date:   2022-12-22 (Thu, 22 Dec 2022)

  Changed paths:
    M Source/JavaScriptCore/API/JSCallbackConstructor.h
    M Source/JavaScriptCore/API/JSCallbackFunction.h
    M Source/JavaScriptCore/API/JSClassRef.h
    M Source/JavaScriptCore/API/JSWeakObjectMapRefInternal.h
    M Source/JavaScriptCore/API/ObjCCallbackFunction.h
    M Source/JavaScriptCore/runtime/ClassInfo.h
    M Source/JavaScriptCore/runtime/Lookup.h

  Log Message:
  -----------
  Cherry-pick 9a7b3938f394. rdar://problem/103604719

    Revert 8350477648f. rdar://103432055

        Revert "Add additional PAC diversity for function pointers in JSC API data structures as we do for vtbls."

        This reverts commit 8350477648f428584eeb8eadadf616e38b5dce75.

    Canonical link: https://commits.webkit.org/252432.1010@safari-7614-branch

Canonical link: https://commits.webkit.org/252432.1010@safari-7614.4.6.1-branch


  Commit: 71efb58fafa8ad4dc89f972f6bd1882f6ad4ad90
      https://github.com/WebKit/WebKit/commit/71efb58fafa8ad4dc89f972f6bd1882f6ad4ad90
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2022-12-22 (Thu, 22 Dec 2022)

  Changed paths:
    R LayoutTests/fast/workers/terminate-worker-with-event-listener-crash-expected.txt
    R LayoutTests/fast/workers/terminate-worker-with-event-listener-crash.html
    M LayoutTests/imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_colno-expected.txt
    M Source/WebCore/Modules/indexeddb/IDBDatabase.cpp
    M Source/WebCore/Modules/indexeddb/IDBRequest.cpp
    M Source/WebCore/Modules/indexeddb/IDBTransaction.cpp
    M Source/WebCore/animation/WebAnimation.cpp
    M Source/WebCore/animation/WebAnimation.h
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/Document.h
    M Source/WebCore/dom/EventTarget.cpp
    M Source/WebCore/dom/ScriptExecutionContext.cpp
    M Source/WebCore/dom/ScriptExecutionContext.h
    M Source/WebCore/history/CachedFrame.cpp
    M Source/WebCore/workers/WorkerGlobalScope.cpp
    M Source/WebCore/workers/WorkerGlobalScope.h
    M Source/WebCore/workers/WorkerOrWorkletGlobalScope.cpp
    M Source/WebCore/workers/service/ServiceWorker.cpp
    M Source/WebCore/workers/service/ServiceWorkerContainer.cpp
    M Source/WebCore/workers/service/ServiceWorkerRegistration.cpp
    M Source/WebCore/workers/service/ServiceWorkerRegistration.h

  Log Message:
  -----------
  Cherry-pick 3a91fd09a076. rdar://problem/103439022

    Unreviewed, revert 252432.807 at safari-7614-branch as it introduced new crashes
    https://bugs.webkit.org/show_bug.cgi?id=249610
    rdar://103439022

    * LayoutTests/fast/workers/terminate-worker-with-event-listener-crash-expected.txt: Removed.
    * LayoutTests/fast/workers/terminate-worker-with-event-listener-crash.html: Removed.
    * LayoutTests/imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_colno-expected.txt:
    * Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:
    (WebCore::IDBDatabase::stop):
    * Source/WebCore/Modules/indexeddb/IDBRequest.cpp:
    (WebCore::IDBRequest::stop):
    * Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:
    (WebCore::IDBTransaction::stop):
    * Source/WebCore/animation/WebAnimation.cpp:
    (WebCore::WebAnimation::stop):
    * Source/WebCore/animation/WebAnimation.h:
    * Source/WebCore/dom/Document.cpp:
    (WebCore::Document::~Document):
    (WebCore::Document::removeAllEventListenersInContext): Deleted.
    * Source/WebCore/dom/Document.h:
    * Source/WebCore/dom/EventTarget.cpp:
    (WebCore::EventTarget::addEventListener):
    (WebCore::EventTarget::removeEventListener):
    (WebCore::EventTarget::removeAllEventListeners):
    * Source/WebCore/dom/ScriptExecutionContext.cpp:
    (WebCore::ScriptExecutionContext::removeAllEventListenersInContext): Deleted.
    (WebCore::ScriptExecutionContext::addEventTargetWithListener): Deleted.
    (WebCore::ScriptExecutionContext::removeEventTargetWithListener): Deleted.
    * Source/WebCore/dom/ScriptExecutionContext.h:
    * Source/WebCore/history/CachedFrame.cpp:
    (WebCore::CachedFrame::destroy):
    * Source/WebCore/workers/WorkerGlobalScope.cpp:
    (WebCore::WorkerGlobalScope::removeAllEventListeners):
    (WebCore::WorkerGlobalScope::removeAllEventListenersInContext): Deleted.
    * Source/WebCore/workers/WorkerGlobalScope.h:
    * Source/WebCore/workers/WorkerOrWorkletGlobalScope.cpp:
    (WebCore::WorkerOrWorkletGlobalScope::prepareForDestruction):
    * Source/WebCore/workers/service/ServiceWorker.cpp:
    (WebCore::ServiceWorker::stop):
    * Source/WebCore/workers/service/ServiceWorkerContainer.cpp:
    (WebCore::ServiceWorkerContainer::stop):
    * Source/WebCore/workers/service/ServiceWorkerRegistration.cpp:
    (WebCore::ServiceWorkerRegistration::stop):
    * Source/WebCore/workers/service/ServiceWorkerRegistration.h:

    Canonical link: https://commits.webkit.org/252432.1014@safari-7614-branch

Canonical link: https://commits.webkit.org/252432.1011@safari-7614.4.6.1-branch


  Commit: 206c4c8842b9ff1bb76470731cf34a379db27fb3
      https://github.com/WebKit/WebKit/commit/206c4c8842b9ff1bb76470731cf34a379db27fb3
  Author: Alan Coon <alancoon at apple.com>
  Date:   2023-01-03 (Tue, 03 Jan 2023)

  Changed paths:
    M Source/JavaScriptCore/Configurations/Version.xcconfig
    M Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
    M Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
    M Source/WebCore/Configurations/Version.xcconfig
    M Source/WebCore/PAL/Configurations/Version.xcconfig
    M Source/WebGPU/Configurations/Version.xcconfig
    M Source/WebInspectorUI/Configurations/Version.xcconfig
    M Source/WebKit/Configurations/Version.xcconfig
    M Source/WebKitLegacy/mac/Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7614.4.6.1.2

Canonical link: https://commits.webkit.org/252432.1012@safari-7614.4.6.1-branch


  Commit: b0ace22dae58ccad759915d275da3d63d5e3a6e2
      https://github.com/WebKit/WebKit/commit/b0ace22dae58ccad759915d275da3d63d5e3a6e2
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-01-03 (Tue, 03 Jan 2023)

  Changed paths:
    A LayoutTests/http/tests/contentfiltering/load-event-in-allowed-subframe-expected.txt
    A LayoutTests/http/tests/contentfiltering/load-event-in-allowed-subframe.html
    A LayoutTests/http/tests/contentfiltering/resources/lots-of-text.html
    M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp

  Log Message:
  -----------
  Cherry-pick 5d11f0377c18. rdar://problem/103247851

    REGRESSION (248723 at main): Videos on bbc.co.uk fail to load when content filtering is enabled
    https://bugs.webkit.org/show_bug.cgi?id=249811
    rdar://103247851

    Reviewed by Brent Fulgham and Alex Christensen.

    On articles on bbc.co.uk, video elements are embedded inside subframes, and are only interactive
    once the containing subframe has finished loading (i.e. dispatched the "load" event). In the case
    where:

    1.  Content filtering is enabled, and also happens in the network process via the
        `CONTENT_FILTERING_IN_NETWORKING_PROCESS` codepath new in iOS 16/macOS Ventura.

    2.  The subframe is loaded from a disk cache entry (as opposed to over the network, or in memory
        cache).

    ...we end up never dispatching the load event on the subframe, due to the fact that the
    corresponding `WebCore::SubresourceLoader` driving the subframe load never gets notified that
    loading finished. This is because, in following code within the network process (in the codepath
    marked below), we exit early after delivering the cached data to the content filter, before either
    sending `WebResourceLoader::DidReceiveResource` or `WebResourceLoader::DidFinishResourceLoad` (the
    latter of which we use in the case where we don't already have a shareable resource handle). To fix
    this, we simply pull the logic to dispatch `WebResourceLoader::DidFinishResourceLoad` out into a
    separate callback, and invoke it from both places.

    ```
        #if ENABLE(SHAREABLE_RESOURCE)
            if (!entry->shareableResourceHandle().isNull()) {
        #if ENABLE(CONTENT_FILTERING_IN_NETWORKING_PROCESS)
                if (m_contentFilter && !m_contentFilter->continueAfterDataReceived(entry->buffer()->makeContiguous(), entry->buffer()->size())) {
                    m_contentFilter->continueAfterNotifyFinished(m_parameters.request.url());
                    m_contentFilter->stopFilteringMainResource();               // <-------
                    return;
                }
        #endif
                send(Messages::WebResourceLoader::DidReceiveResource(entry->shareableResourceHandle()));
                return;
            }
        #endif
    ```

    Note that we prefer dispatching `DidFinishResourceLoad` over `DidReceiveResource` below (which we
    would normally use in this shareable resource handle codepath), since the resource loader in the web
    process would already have received the data when content filtering is enabled, so sending the
    entire cached resource handle again is redundant.

    Test: http/tests/contentfiltering/load-event-in-allowed-subframe.html

    * LayoutTests/http/tests/contentfiltering/load-event-in-allowed-subframe-expected.txt: Added.
    * LayoutTests/http/tests/contentfiltering/load-event-in-allowed-subframe.html: Added.
    * LayoutTests/http/tests/contentfiltering/resources/lots-of-text.html: Added.

    Add a new test resource that consists of an HTML page that contains a large amount of text. This
    ensures that we'll attempt to store it in disk cache, which is a necessary part of reproducing this
    bug.

    * Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
    (WebKit::NetworkResourceLoader::sendResultForCacheEntry):

    Dispatch `WebResourceLoader::DidFinishResourceLoad` in both content filtering codepaths when
    `CONTENT_FILTERING_IN_NETWORKING_PROCESS` is enabled.

    Canonical link: https://commits.webkit.org/258394@main

Canonical link: https://commits.webkit.org/252432.1013@safari-7614.4.6.1-branch


  Commit: 3c0d968a97fec1421b70cee9d59e153a41452b94
      https://github.com/WebKit/WebKit/commit/3c0d968a97fec1421b70cee9d59e153a41452b94
  Author: Alan Coon <alancoon at apple.com>
  Date:   2023-01-04 (Wed, 04 Jan 2023)

  Changed paths:
    M Source/JavaScriptCore/Configurations/Version.xcconfig
    M Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
    M Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
    M Source/WebCore/Configurations/Version.xcconfig
    M Source/WebCore/PAL/Configurations/Version.xcconfig
    M Source/WebGPU/Configurations/Version.xcconfig
    M Source/WebInspectorUI/Configurations/Version.xcconfig
    M Source/WebKit/Configurations/Version.xcconfig
    M Source/WebKitLegacy/mac/Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7614.4.6.1.3

Canonical link: https://commits.webkit.org/252432.1014@safari-7614.4.6.1-branch


  Commit: e9849e674f32d27ece2cefe12602f979ef25a129
      https://github.com/WebKit/WebKit/commit/e9849e674f32d27ece2cefe12602f979ef25a129
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-01-04 (Wed, 04 Jan 2023)

  Changed paths:
    A LayoutTests/fast/forms/datalist/datalist-id-change-crash-expected.txt
    A LayoutTests/fast/forms/datalist/datalist-id-change-crash.html
    M Source/WebCore/html/HTMLInputElement.cpp

  Log Message:
  -----------
  Cherry-pick 3be45019e7fd. rdar://problem/103823004

    Crash in HTMLInputElement::dataListMayHaveChanged via ListAttributeTargetObserver::idTargetChanged
    https://bugs.webkit.org/show_bug.cgi?id=250039

    Reviewed by Wenson Hsieh, Geoffrey Garen and Aditya Keerthi.

    Merge https://commits.webkit.org/253773@main to avoid hitting this crash.

    * LayoutTests/fast/forms/datalist/datalist-id-change-crash-expected.txt: Added.
    * LayoutTests/fast/forms/datalist/datalist-id-change-crash.html: Added.
    * Source/WebCore/html/HTMLInputElement.cpp:
    (WebCore::HTMLInputElement::resetListAttributeTargetObserver):
    (WebCore::ListAttributeTargetObserver::ListAttributeTargetObserver):

    Canonical link: https://commits.webkit.org/252432.1015@safari-7614-branch

Canonical link: https://commits.webkit.org/252432.1015@safari-7614.4.6.1-branch


  Commit: dcf5f2c44b502b9b482d3ed946d397876d9feb9a
      https://github.com/WebKit/WebKit/commit/dcf5f2c44b502b9b482d3ed946d397876d9feb9a
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2023-01-04 (Wed, 04 Jan 2023)

  Changed paths:
    A LayoutTests/media/audio-session-category-unmute-mute-expected.txt
    A LayoutTests/media/audio-session-category-unmute-mute.html
    M LayoutTests/media/video-test.js
    M LayoutTests/platform/gtk/TestExpectations
    M Source/WebCore/platform/audio/PlatformMediaSession.cpp
    M Source/WebCore/platform/audio/PlatformMediaSession.h
    M Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm
    M Source/WebCore/platform/audio/glib/MediaSessionManagerGLib.cpp

  Log Message:
  -----------
  Cherry-pick 2ed67ffbd825. rdar://problem/103408312

    [iOS] Changing the mute state of autoplaying silent videos can interrupt system audio
    https://bugs.webkit.org/show_bug.cgi?id=249408
    rdar://103408312

    Reviewed by Eric Carlson.

    WebKit will attempt to leave the default AVAudioSession category in "ambient"
    when no audible playback exists. However, when an audible media element pauses,
    WebKit will leave the category in "media playback", which allows APIs like Now
    Playing to continue working. It does this by tracking, for each media element,
    that the element has played sometime since the last time WebKit received an
    interruption. The assumption is that elements which have previously played
    should not cause the category to drop to "none" when they pause.

    However, this logic gets confused when a previously silent media element
    (i.e., muted) pauses, then becomes not-silent (i.e., unmuted). The
    PlatformMediaSessionManager sees that the element is capable of producing
    audio, and has played since the last interruption, so sets the AVAudioSession
    category to "media playback". When that element is then played, AVFoundation
    will activate the AVAudioSession, which by virtue of being configured for
    "media playback", will interrupt other system audio.

    To resolve this, rather than tracking whether the element has "played since the
    last interruption", track whether the element has "played _audibly_ since the
    last interruption." Rename hasPlayedSinceLastInterruption() ->
    hasPlayedAudiblySinceLastInterruption() to clarify the new behavior.

    * LayoutTests/media/audio-session-category-unmute-mute-expected.txt: Added.
    * LayoutTests/media/audio-session-category-unmute-mute.html: Added.
    * Source/WebCore/platform/audio/PlatformMediaSession.cpp:
    (WebCore::PlatformMediaSession::setState):
    * Source/WebCore/platform/audio/PlatformMediaSession.h:
    (WebCore::PlatformMediaSession::hasPlayedAudiblySinceLastInterruption const):
    (WebCore::PlatformMediaSession::clearHasPlayedAudiblySinceLastInterruption):
    (WebCore::PlatformMediaSession::hasPlayedSinceLastInterruption const): Deleted.
    (WebCore::PlatformMediaSession::clearHasPlayedSinceLastInterruption): Deleted.
    * Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm:
    (WebCore::MediaSessionManagerCocoa::updateSessionState):
    (WebCore::MediaSessionManagerCocoa::beginInterruption):

    Canonical link: https://commits.webkit.org/258000@main

Canonical link: https://commits.webkit.org/252432.1016@safari-7614.4.6.1-branch


  Commit: a0b298741e3393334616af7d04be33c0a7199141
      https://github.com/WebKit/WebKit/commit/a0b298741e3393334616af7d04be33c0a7199141
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2023-01-04 (Wed, 04 Jan 2023)

  Changed paths:
    A LayoutTests/fast/scrolling/mac/smooth-scroll-with-overflow-hidden-and-layout-expected.txt
    A LayoutTests/fast/scrolling/mac/smooth-scroll-with-overflow-hidden-and-layout.html
    M LayoutTests/fast/scrolling/mac/smooth-scroll-with-overflow-hidden.html
    M Source/WebCore/platform/ScrollableArea.h
    M Source/WebCore/rendering/RenderLayerScrollableArea.cpp

  Log Message:
  -----------
  Cherry-pick ca608f18f089. rdar://problem/103539448

    The "Around the World" carousel is broken on https://focal-theme-carbon.myshopify.com/
    https://bugs.webkit.org/show_bug.cgi?id=242224
    <rdar://96453957>

    Reviewed by Tim Horton.

    251454 at main fixed a bug where an animated programmatic scroll on an `overflow:hidden` element failed to scroll
    because we didn't register the ScrollableArea with the FrameView.

    However, if layout runs while the scroll is in progress, then we unregister the ScrollableArea, which
    prematurely stops the scrolling. Fix by having `RenderLayerScrollableArea::updateScrollableAreaSet()`
    check to see if an animated scroll is active before unregistering.

    * LayoutTests/fast/scrolling/mac/smooth-scroll-with-overflow-hidden-and-layout-expected.txt: Added.
    * LayoutTests/fast/scrolling/mac/smooth-scroll-with-overflow-hidden-and-layout.html: Copied from LayoutTests/fast/scrolling/mac/smooth-scroll-with-overflow-hidden.html.
    * LayoutTests/fast/scrolling/mac/smooth-scroll-with-overflow-hidden.html: Remove a redundant rule.
    * Source/WebCore/platform/ScrollableArea.h: m_hasActiveScrollAnimation was unused, so remove it.
    * Source/WebCore/rendering/RenderLayerScrollableArea.cpp:
    (WebCore::RenderLayerScrollableArea::updateScrollableAreaSet):

    Canonical link: https://commits.webkit.org/253493@main

Canonical link: https://commits.webkit.org/252432.1017@safari-7614.4.6.1-branch


  Commit: eb8fdd4cf8c773eb6a05718ca6a824ef2468bb88
      https://github.com/WebKit/WebKit/commit/eb8fdd4cf8c773eb6a05718ca6a824ef2468bb88
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-01-04 (Wed, 04 Jan 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderLayerScrollableArea.cpp

  Log Message:
  -----------
  Cherry-pick 711178d9ca19. rdar://problem/103539448

    The "Around the World" carousel is broken on https://focal-theme-carbon.myshopify.com/
    https://bugs.webkit.org/show_bug.cgi?id=242224

    Unreviewed iOS build fix.

    * Source/WebCore/rendering/RenderLayerScrollableArea.cpp:
    (WebCore::RenderLayerScrollableArea::updateScrollableAreaSet):

    Canonical link: https://commits.webkit.org/253511@main

Canonical link: https://commits.webkit.org/252432.1018@safari-7614.4.6.1-branch


  Commit: e0ff01e737f0c4f15c1be99c0498b7fca5f7ce1a
      https://github.com/WebKit/WebKit/commit/e0ff01e737f0c4f15c1be99c0498b7fca5f7ce1a
  Author: Alan Coon <alancoon at apple.com>
  Date:   2023-01-04 (Wed, 04 Jan 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderLayerScrollableArea.cpp

  Log Message:
  -----------
  Revert 711178d9ca19. rdar://problem/103539448

This reverts commit eb8fdd4cf8c773eb6a05718ca6a824ef2468bb88.

Canonical link: https://commits.webkit.org/252432.1019@safari-7614.4.6.1-branch


  Commit: 9e901369afcd09fc3763f8c68d8831f7344230f8
      https://github.com/WebKit/WebKit/commit/9e901369afcd09fc3763f8c68d8831f7344230f8
  Author: Alan Coon <alancoon at apple.com>
  Date:   2023-01-04 (Wed, 04 Jan 2023)

  Changed paths:
    R LayoutTests/fast/scrolling/mac/smooth-scroll-with-overflow-hidden-and-layout-expected.txt
    R LayoutTests/fast/scrolling/mac/smooth-scroll-with-overflow-hidden-and-layout.html
    M LayoutTests/fast/scrolling/mac/smooth-scroll-with-overflow-hidden.html
    M Source/WebCore/platform/ScrollableArea.h
    M Source/WebCore/rendering/RenderLayerScrollableArea.cpp

  Log Message:
  -----------
  Revert ca608f18f089. rdar://problem/103539448

This reverts commit a0b298741e3393334616af7d04be33c0a7199141.

Canonical link: https://commits.webkit.org/252432.1020@safari-7614.4.6.1-branch


  Commit: b405abdfd31a412857fa5fa9f52db57332652a1d
      https://github.com/WebKit/WebKit/commit/b405abdfd31a412857fa5fa9f52db57332652a1d
  Author: Alan Coon <alancoon at apple.com>
  Date:   2023-01-04 (Wed, 04 Jan 2023)

  Changed paths:
    R LayoutTests/media/audio-session-category-unmute-mute-expected.txt
    R LayoutTests/media/audio-session-category-unmute-mute.html
    M LayoutTests/media/video-test.js
    M LayoutTests/platform/gtk/TestExpectations
    M Source/WebCore/platform/audio/PlatformMediaSession.cpp
    M Source/WebCore/platform/audio/PlatformMediaSession.h
    M Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm
    M Source/WebCore/platform/audio/glib/MediaSessionManagerGLib.cpp

  Log Message:
  -----------
  Revert 2ed67ffbd825. rdar://problem/103408312

This reverts commit dcf5f2c44b502b9b482d3ed946d397876d9feb9a.

Canonical link: https://commits.webkit.org/252432.1021@safari-7614.4.6.1-branch


  Commit: 87e96ff119f524c67828ab69b832c630d84fb074
      https://github.com/WebKit/WebKit/commit/87e96ff119f524c67828ab69b832c630d84fb074
  Author: Alan Coon <alancoon at apple.com>
  Date:   2023-01-04 (Wed, 04 Jan 2023)

  Changed paths:
    A LayoutTests/fast/scrolling/mac/smooth-scroll-with-overflow-hidden-and-layout-expected.txt
    A LayoutTests/fast/scrolling/mac/smooth-scroll-with-overflow-hidden-and-layout.html
    M LayoutTests/fast/scrolling/mac/smooth-scroll-with-overflow-hidden.html
    M Source/WebCore/platform/ScrollableArea.h
    M Source/WebCore/rendering/RenderLayerScrollableArea.cpp

  Log Message:
  -----------
  Cherry-pick ca608f18f089. rdar://problem/103539448

This reverts commit 9e901369afcd09fc3763f8c68d8831f7344230f8.

Canonical link: https://commits.webkit.org/252432.1022@safari-7614.4.6.1-branch


  Commit: 97c0b51bcb8810d13998d5ae4c6320fc617538e3
      https://github.com/WebKit/WebKit/commit/97c0b51bcb8810d13998d5ae4c6320fc617538e3
  Author: Alan Coon <alancoon at apple.com>
  Date:   2023-01-04 (Wed, 04 Jan 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderLayerScrollableArea.cpp

  Log Message:
  -----------
  Cherry-pick 711178d9ca19. rdar://problem/103539448

This reverts commit e0ff01e737f0c4f15c1be99c0498b7fca5f7ce1a.

Canonical link: https://commits.webkit.org/252432.1023@safari-7614.4.6.1-branch


  Commit: b1877c25d38e8eaea36121b043f10b57c8025c99
      https://github.com/WebKit/WebKit/commit/b1877c25d38e8eaea36121b043f10b57c8025c99
  Author: Alan Coon <alancoon at apple.com>
  Date:   2023-01-05 (Thu, 05 Jan 2023)

  Changed paths:
    M Source/JavaScriptCore/Configurations/Version.xcconfig
    M Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
    M Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
    M Source/WebCore/Configurations/Version.xcconfig
    M Source/WebCore/PAL/Configurations/Version.xcconfig
    M Source/WebGPU/Configurations/Version.xcconfig
    M Source/WebInspectorUI/Configurations/Version.xcconfig
    M Source/WebKit/Configurations/Version.xcconfig
    M Source/WebKitLegacy/mac/Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7614.4.6.1.4

Canonical link: https://commits.webkit.org/252432.1024@safari-7614.4.6.1-branch


  Commit: fe183f6e628b4404077453bdb6e6c3dee86a1830
      https://github.com/WebKit/WebKit/commit/fe183f6e628b4404077453bdb6e6c3dee86a1830
  Author: Eric Carlson <eric.carlson at apple.com>
  Date:   2023-01-05 (Thu, 05 Jan 2023)

  Changed paths:
    A LayoutTests/media/media-source/content/test-red-3s-480x360.png
    A LayoutTests/media/media-source/media-source-video-renders-expected.html
    A LayoutTests/media/media-source/media-source-video-renders.html
    M LayoutTests/media/utilities.js
    M Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml

  Log Message:
  -----------
  Cherry-pick ba5d6a18a598. rdar://problem/103696863

    [Cocoa, MSE] MSE video doesn't render in WK1 WebView
    https://bugs.webkit.org/show_bug.cgi?id=250105
    rdar://103696863

    Reviewed by Wenson Hsieh.

    252183 at main (rdar://96256430) updated the `MediaPlayerPrivateMediaSourceAVFObjC` logic for
    rendering with an AVSampleBufferDisplayLayer or with a decompression session. The logic
    includes a check of the `mediaSourceInlinePaintingEnabled` runtime flag, which is off by
    default in WebKit 1, so it inadvertently disabled video in legacy WebViews.

    * LayoutTests/media/media-source/content/test-red-3s-480x360.png: Added.
    * LayoutTests/media/media-source/media-source-video-renders-expected.html: Added.
    * LayoutTests/media/media-source/media-source-video-renders.html: Added.
    * LayoutTests/media/utilities.js:
    * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Make the MediaSourceInlinePaintingEnabled
    WebKitLegacy default the same as WebKit.

    Canonical link: https://commits.webkit.org/258499@main

Canonical link: https://commits.webkit.org/252432.1025@safari-7614.4.6.1-branch


  Commit: 461224ab806b2799620cbbc9654c09401892eb74
      https://github.com/WebKit/WebKit/commit/461224ab806b2799620cbbc9654c09401892eb74
  Author: Alan Coon <alancoon at apple.com>
  Date:   2023-01-05 (Thu, 05 Jan 2023)

  Changed paths:
    R LayoutTests/media/media-source/content/test-red-3s-480x360.png
    R LayoutTests/media/media-source/media-source-video-renders-expected.html
    R LayoutTests/media/media-source/media-source-video-renders.html
    M LayoutTests/media/utilities.js
    M Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml

  Log Message:
  -----------
  Revert ba5d6a18a598. rdar://problem/103696863

This reverts commit fe183f6e628b4404077453bdb6e6c3dee86a1830.

Canonical link: https://commits.webkit.org/252432.1026@safari-7614.4.6.1-branch


  Commit: 492d349d2b7dfb8a5579f3f0e0f57b0c589be6cb
      https://github.com/WebKit/WebKit/commit/492d349d2b7dfb8a5579f3f0e0f57b0c589be6cb
  Author: Alan Coon <alancoon at apple.com>
  Date:   2023-01-06 (Fri, 06 Jan 2023)

  Changed paths:
    M Source/JavaScriptCore/Configurations/Version.xcconfig
    M Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
    M Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
    M Source/WebCore/Configurations/Version.xcconfig
    M Source/WebCore/PAL/Configurations/Version.xcconfig
    M Source/WebGPU/Configurations/Version.xcconfig
    M Source/WebInspectorUI/Configurations/Version.xcconfig
    M Source/WebKit/Configurations/Version.xcconfig
    M Source/WebKitLegacy/mac/Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7614.4.6.1.5

Canonical link: https://commits.webkit.org/252432.1027@safari-7614.4.6.1-branch


  Commit: f3534e9a4f49eb0d1ebc8100118df8255ad74faa
      https://github.com/WebKit/WebKit/commit/f3534e9a4f49eb0d1ebc8100118df8255ad74faa
  Author: Eric Carlson <eric.carlson at apple.com>
  Date:   2023-01-06 (Fri, 06 Jan 2023)

  Changed paths:
    A LayoutTests/media/media-source/content/test-red-3s-480x360.png
    A LayoutTests/media/media-source/media-source-video-renders-expected.html
    A LayoutTests/media/media-source/media-source-video-renders.html
    M LayoutTests/media/utilities.js
    M Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml

  Log Message:
  -----------
  Cherry-pick ba5d6a18a598. rdar://problem/103696863

    [Cocoa, MSE] MSE video doesn't render in WK1 WebView
    https://bugs.webkit.org/show_bug.cgi?id=250105
    rdar://103696863

    Reviewed by Wenson Hsieh.

    252183 at main (rdar://96256430) updated the `MediaPlayerPrivateMediaSourceAVFObjC` logic for
    rendering with an AVSampleBufferDisplayLayer or with a decompression session. The logic
    includes a check of the `mediaSourceInlinePaintingEnabled` runtime flag, which is off by
    default in WebKit 1, so it inadvertently disabled video in legacy WebViews.

    * LayoutTests/media/media-source/content/test-red-3s-480x360.png: Added.
    * LayoutTests/media/media-source/media-source-video-renders-expected.html: Added.
    * LayoutTests/media/media-source/media-source-video-renders.html: Added.
    * LayoutTests/media/utilities.js:
    * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Make the MediaSourceInlinePaintingEnabled
    WebKitLegacy default the same as WebKit.

    Canonical link: https://commits.webkit.org/258499@main

Canonical link: https://commits.webkit.org/252432.1028@safari-7614.4.6.1-branch


  Commit: 75828561de9c2ebb08099c671bf29f8c34b8a940
      https://github.com/WebKit/WebKit/commit/75828561de9c2ebb08099c671bf29f8c34b8a940
  Author: Myah Cobbs <mcobbs at apple.com>
  Date:   2023-02-08 (Wed, 08 Feb 2023)

  Changed paths:
    M Source/JavaScriptCore/Configurations/Version.xcconfig
    M Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
    M Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
    M Source/WebCore/Configurations/Version.xcconfig
    M Source/WebCore/PAL/Configurations/Version.xcconfig
    M Source/WebGPU/Configurations/Version.xcconfig
    M Source/WebInspectorUI/Configurations/Version.xcconfig
    M Source/WebKit/Configurations/Version.xcconfig
    M Source/WebKitLegacy/mac/Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7614.4.6.1.6

Canonical link: https://commits.webkit.org/252432.1029@safari-7614.4.6.1-branch


  Commit: 6b690064b8876b2319186ca60927199c57340028
      https://github.com/WebKit/WebKit/commit/6b690064b8876b2319186ca60927199c57340028
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2023-02-08 (Wed, 08 Feb 2023)

  Changed paths:
    M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h

  Log Message:
  -----------
  Cherry-pick 1b2eb138ef92. rdar://problem/105175786

    [JSC] ToThis object folding should check if AbstractValue is always an object
    https://bugs.webkit.org/show_bug.cgi?id=251944
    rdar://105175786

    Reviewed by Geoffrey Garen and Mark Lam.

    ToThis can become Identity for strict mode if it is just primitive values or its object does not have toThis function overriding.
    This is correct, but folding ToThis to Undefined etc. (not Identity) needs to check that an input only contains objects.
    This patch adds appropriate checks to prevent from converting ToThis(GlobalObject | Int32) to Undefined for example.

    * Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:
    (JSC::DFG::isToThisAnIdentity):

    Canonical link: https://commits.webkit.org/259548.63@safari-7615-branch

Canonical link: https://commits.webkit.org/252432.1030@safari-7614.4.6.1-branch


Compare: https://github.com/WebKit/WebKit/compare/e988c7897e40%5E...6b690064b887


More information about the webkit-changes mailing list