[webkit-changes] [WebKit/WebKit] 53d70e: Avoid unnecessary is8Bit() check for each string i...

Chris Dumez noreply at github.com
Mon Mar 27 13:32:47 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 53d70e1e2b39bf325d390def9e7a115634d40fb5
      https://github.com/WebKit/WebKit/commit/53d70e1e2b39bf325d390def9e7a115634d40fb5
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-03-27 (Mon, 27 Mar 2023)

  Changed paths:
    M Source/JavaScriptCore/runtime/JSStringJoiner.cpp

  Log Message:
  -----------
  Avoid unnecessary is8Bit() check for each string in JSStringJoiner when m_isAll8Bit is true
https://bugs.webkit.org/show_bug.cgi?id=254485

Reviewed by Yusuke Suzuki.

When JSStringJoiner::m_isAll8Bit is true, the output buffer will be a LChar*
and there is no point is calling StringView::is8Bit() for each string in
m_strings. Call StringView::getCharacters8() instead of StringView::getCharacters()
in this case.

* Source/JavaScriptCore/runtime/JSStringJoiner.cpp:
(JSC::appendStringToData):

Canonical link: https://commits.webkit.org/262172@main




More information about the webkit-changes mailing list