[webkit-changes] [WebKit/WebKit] fd637a: [IFC] Incorrect out-of-flow box placement when tex...

Alan Baradlay noreply at github.com
Mon Mar 27 12:58:10 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fd637abec43903daad7b1f87e845cbca84e5410f
      https://github.com/WebKit/WebKit/commit/fd637abec43903daad7b1f87e845cbca84e5410f
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-03-27 (Mon, 27 Mar 2023)

  Changed paths:
    A LayoutTests/fast/inline/out-of-flow-inline-with-text-indent-on-last-line-expected.html
    A LayoutTests/fast/inline/out-of-flow-inline-with-text-indent-on-last-line.html
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.h

  Log Message:
  -----------
  [IFC] Incorrect out-of-flow box placement when text-indent is present (display: inline)
https://bugs.webkit.org/show_bug.cgi?id=254492

Reviewed by Antti Koivisto.

Take text-ident (mainly each-line) into account when computing the static position for a "display: inline" out-of-flow box
on "overflowing line" after the last line with inline content.

* LayoutTests/fast/inline/out-of-flow-inline-with-text-indent-on-last-line-expected.html: Added.
* LayoutTests/fast/inline/out-of-flow-inline-with-text-indent-on-last-line.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp:
(WebCore::Layout::InlineFormattingGeometry::lineBoxOffsetAfterLastLine const):
(WebCore::Layout::InlineFormattingGeometry::staticPositionForOutOfFlowInlineLevelBox const):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.h:

Canonical link: https://commits.webkit.org/262170@main




More information about the webkit-changes mailing list