[webkit-changes] [WebKit/WebKit] ecef01: Remove legacy build system script phases and build...

[Elliott Williams]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ecef01756ff919331c08e4e2a820cb4d58089257
      https://github.com/WebKit/WebKit/commit/ecef01756ff919331c08e4e2a820cb4d58089257
  Author: Elliott Williams <emw at apple.com>
  Date:   2023-03-27 (Mon, 27 Mar 2023)

  Changed paths:
    M Source/JavaScriptCore/Configurations/Base.xcconfig
    M Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig
    M Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig
    M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
    M Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj
    M Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig
    M Source/ThirdParty/ANGLE/Configurations/Base.xcconfig
    M Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig
    M Source/ThirdParty/libwebrtc/Configurations/libabsl.xcconfig
    M Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig
    M Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj
    M Source/WTF/Configurations/Base.xcconfig
    M Source/WTF/Configurations/WTF.xcconfig
    M Source/WTF/WTF.xcodeproj/project.pbxproj
    M Source/WebCore/PAL/Configurations/Base.xcconfig
    M Source/WebCore/PAL/Configurations/PAL.xcconfig
    M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
    M Source/WebGPU/Configurations/Base.xcconfig
    M Source/WebGPU/Configurations/WGSL.xcconfig
    M Source/WebKit/Configurations/Base.xcconfig
    M Source/WebKit/Configurations/WebKit.xcconfig
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj
    M Source/WebKitLegacy/mac/Configurations/Base.xcconfig
    M Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig
    M Tools/DumpRenderTree/mac/Configurations/Base.xcconfig
    M Tools/DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig
    M Tools/DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig
    M Tools/TestWebKitAPI/Configurations/Base.xcconfig
    M Tools/TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig

  Log Message:
  -----------
  Remove legacy build system script phases and build settings
https://bugs.webkit.org/show_bug.cgi?id=243221
rdar://89701972

Reviewed by Alexey Proskuryakov.

Delete WK_WHICH_BUILD_SYSTEM and WK_USE_NEW_BUILD_SYSTEM settings.
Remove script phases which checked these settings and do nothing under
XCBuild.

* Source/JavaScriptCore/Configurations/Base.xcconfig:
* Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig:
* Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig:

* Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
  - Add new target dependencies from JavaScriptCore to the LLInt
    targets, now that the legacy-only aggregate targets are gone.
  - Use TARGET_BUILD_DIR, not BUILT_PRODUCTS_DIR, in the path to
    JSCLLIntSettingsExtractor. The former is needed for the task
    dependency to be picked up in install-style builds (this was the
    cause of an earlier revert).

* Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj:
* Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig:
* Source/ThirdParty/ANGLE/Configurations/Base.xcconfig:
* Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:
* Source/ThirdParty/libwebrtc/Configurations/libabsl.xcconfig:
* Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig:
* Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj:
* Source/WTF/Configurations/Base.xcconfig:
* Source/WTF/Configurations/WTF.xcconfig:
* Source/WTF/WTF.xcodeproj/project.pbxproj:
* Source/WebCore/PAL/Configurations/Base.xcconfig:
* Source/WebCore/PAL/Configurations/PAL.xcconfig:
* Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:
* Source/WebGPU/Configurations/Base.xcconfig:
* Source/WebGPU/Configurations/WGSL.xcconfig:
* Source/WebKit/Configurations/Base.xcconfig:
* Source/WebKit/Configurations/WebKit.xcconfig:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj:
* Source/WebKitLegacy/mac/Configurations/Base.xcconfig:
* Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:
* Tools/DumpRenderTree/mac/Configurations/Base.xcconfig:
* Tools/DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
* Tools/DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
* Tools/TestWebKitAPI/Configurations/Base.xcconfig:
* Tools/TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig:

Canonical link: https://commits.webkit.org/262162@main