[webkit-changes] [WebKit/WebKit] 0a0fdf: Regression(262103 at main) JSRopeString::resolveRopeT...

Chris Dumez noreply at github.com
Mon Mar 27 10:32:03 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0a0fdf90f82f7457cf030541a55c249443805005
      https://github.com/WebKit/WebKit/commit/0a0fdf90f82f7457cf030541a55c249443805005
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-03-27 (Mon, 27 Mar 2023)

  Changed paths:
    M Source/JavaScriptCore/runtime/JSString.cpp

  Log Message:
  -----------
  Regression(262103 at main) JSRopeString::resolveRopeToAtomString() no longer reports extra memory
https://bugs.webkit.org/show_bug.cgi?id=254474

Reviewed by Yusuke Suzuki.

JSRopeString::resolveRopeToAtomString() no longer reports extra memory since 262103 at main.
Because we're holding the resolved rope as an AtomString, `valueInternal().impl()->hasOneRef()`
could never be true.

* Source/JavaScriptCore/runtime/JSString.cpp:
(JSC::JSRopeString::resolveRopeToAtomString const):

Canonical link: https://commits.webkit.org/262158@main




More information about the webkit-changes mailing list