[webkit-changes] [WebKit/WebKit] 6e5f0f: [IFC] Incorrect out-of-flow box placement when tex...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6e5f0fcfcc56f1a332119bbc5a26864f00449d26
      https://github.com/WebKit/WebKit/commit/6e5f0fcfcc56f1a332119bbc5a26864f00449d26
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-03-27 (Mon, 27 Mar 2023)

  Changed paths:
    A LayoutTests/fast/inline/out-of-flow-inline-with-text-align-on-last-line-expected.html
    A LayoutTests/fast/inline/out-of-flow-inline-with-text-align-on-last-line.html
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.h

  Log Message:
  -----------
  [IFC] Incorrect out-of-flow box placement when text-align is not start (display: inline)
https://bugs.webkit.org/show_bug.cgi?id=254477

Reviewed by Antti Koivisto.

Take horizontal alignment into account when computing the static position for a "display: inline" out-of-flow box.
(This is also a progression compared to legacy line layout for text-align-last).

* LayoutTests/fast/inline/out-of-flow-inline-with-text-align-on-last-line-expected.html: Added.
* LayoutTests/fast/inline/out-of-flow-inline-with-text-align-on-last-line.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):
(WebCore::Layout::InlineFormattingContext::layoutInFlowContentForIntegration):
(WebCore::Layout::InlineFormattingContext::computeStaticPositionForOutOfFlowContent):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h:
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp:
(WebCore::Layout::InlineFormattingGeometry::staticPositionForOutOfFlowInlineLevelBox const):
(WebCore::Layout::InlineFormattingGeometry::staticPositionForOutOfFlowBlockLevelBox const):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.h:

Canonical link: https://commits.webkit.org/262154@main