[webkit-changes] [WebKit/WebKit] 9a18fa: [ews-build.webkit.org] Make GitHubMixin.get_pr_jso...

Jonathan Bedard noreply at github.com
Mon Mar 27 08:25:02 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9a18fa3e56d455bd835f9a660ad9f6d3d1fa01ed
      https://github.com/WebKit/WebKit/commit/9a18fa3e56d455bd835f9a660ad9f6d3d1fa01ed
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2023-03-27 (Mon, 27 Mar 2023)

  Changed paths:
    M Tools/CISupport/ews-build/steps.py

  Log Message:
  -----------
  [ews-build.webkit.org] Make GitHubMixin.get_pr_json asynchronous
https://bugs.webkit.org/show_bug.cgi?id=254446
rdar://107207345

Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/steps.py:
(GitHubMixin):
(GitHubMixin.get_pr_json): Use Twisted's asynchronous request library
and make function asynchronous.
(GitHubMixin.should_send_email_for_pr): get_pr_json is not asynchronous.
(ValidateChange.validate_github): Ditto.
(BlockPullRequest.run): Ditto.
(GitHubMixin.fetch_data_from_url_with_authentication_github_old): Deleted.

Canonical link: https://commits.webkit.org/262151@main




More information about the webkit-changes mailing list