[webkit-changes] [WebKit/WebKit] e9c9b4: [mac][ios][win] CodecDelay webm field isn't being ...

[Enrique Ocaña González]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e9c9b4fd0c9c6866574c7c32d6f535fc8f823f66
      https://github.com/WebKit/WebKit/commit/e9c9b4fd0c9c6866574c7c32d6f535fc8f823f66
  Author: Enrique Ocaña González <eocanha at igalia.com>
  Date:   2023-03-27 (Mon, 27 Mar 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    A LayoutTests/media/media-source/content/test-opus-codecdelay-manifest.json
    A LayoutTests/media/media-source/content/test-opus-codecdelay.webm
    M LayoutTests/media/media-source/content/test-opus.webm
    A LayoutTests/media/media-source/media-webm-opus-codecdelay-expected.txt
    A LayoutTests/media/media-source/media-webm-opus-codecdelay.html
    M LayoutTests/platform/glib/TestExpectations

  Log Message:
  -----------
  [mac][ios][win] CodecDelay webm field isn't being honored
https://bugs.webkit.org/show_bug.cgi?id=254222

All the platforms except glib (GStreamer) are ignoring the CodecDelay[1] field
in the webm/matroska Track element. The value in this field must be subtracted
to the timestamps generated by the demuxer.

As this isn't being done by the majority of the ports, the expected values in
media/media-source/media-webm-opus-partial-abort.html, which uses a
media/media-source/content/test-opus.webm file with CodecDelay, are plainly
wrong and the glib port is unfairly failing that test.

This commit modifies the test-opus.webm file to have a CodecDelay field of
zero (so the expected values now apply equally to all the platforms, including
glib/GStreamer).

A new media-webm-opus-codecdelay.html test which uses the original
test-opus.webm file (now renamed as test-opus-codecdelay.webm) has been added.
This test passes on glib and is expected to fail on all the other platforms, so
they are aware of the problem.

[1] https://www.matroska.org/technical/elements.html

Reviewed by Alicia Boya Garcia.

* LayoutTests/TestExpectations: Make the new test fail for all the platforms.
* LayoutTests/media/media-source/content/test-opus-codecdelay-manifest.json: Added.
* LayoutTests/media/media-source/content/test-opus-codecdelay.webm: Copied from LayoutTests/media/media-source/content/test-opus.webm.
* LayoutTests/media/media-source/content/test-opus.webm: CodecDelay field zeroed.
* LayoutTests/media/media-source/media-webm-opus-codecdelay-expected.txt: Added.
* LayoutTests/media/media-source/media-webm-opus-codecdelay.html: Added.
* LayoutTests/platform/glib/TestExpectations: Make the new test pass on glib/GStreamer.

Canonical link: https://commits.webkit.org/262143@main