[webkit-changes] [WebKit/WebKit] b223a0: [GStreamer] Clarify video sample passing semantics...

Philippe Normand noreply at github.com
Mon Mar 27 01:38:56 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b223a07ae64ec413b5d9289a56f255f08884cae8
      https://github.com/WebKit/WebKit/commit/b223a07ae64ec413b5d9289a56f255f08884cae8
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-03-27 (Mon, 27 Mar 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h

  Log Message:
  -----------
  [GStreamer] Clarify video sample passing semantics between video sink and player
https://bugs.webkit.org/show_bug.cgi?id=254404

Reviewed by Xabier Rodriguez-Calvar.

The player `triggerRepaint()` was reworked to make sample ownership passing more explicit.

* Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp:
(webKitVideoSinkSetMediaPlayerPrivate):
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::triggerRepaint):
(WebCore::MediaPlayerPrivateGStreamer::createVideoSink):
(WebCore::MediaPlayerPrivateGStreamer::repaintCallback): Deleted.
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

Canonical link: https://commits.webkit.org/262138@main




More information about the webkit-changes mailing list