[webkit-changes] [WebKit/WebKit] b9bac1: REGRESSION (260675 at main): [ macOS, iOS ] 2 x fast/...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b9bac132dda71039c370fc0cd80455bc1b03b5c4
      https://github.com/WebKit/WebKit/commit/b9bac132dda71039c370fc0cd80455bc1b03b5c4
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-03-25 (Sat, 25 Mar 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/fast/text/font-weight-download-3-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/fallback-remote-to-data-url-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-display/font-display-failure-fallback-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-stretch-properties-001-expected.txt
    M LayoutTests/platform/mac-wk2/TestExpectations
    M Source/WTF/wtf/PlatformUse.h
    M Source/WebCore/platform/graphics/ComplexTextController.cpp
    M Source/WebCore/platform/graphics/Font.h
    M Source/WebCore/platform/graphics/FontCascade.cpp
    M Source/WebCore/rendering/RenderText.cpp

  Log Message:
  -----------
  REGRESSION (260675 at main): [ macOS, iOS ] 2 x fast/text/glyph-display-lis t tests are a constant failure.
https://bugs.webkit.org/show_bug.cgi?id=252866
<rdar://105854585>

Reviewed by Myles C. Maxfield.

Accessing glyph data initiates font loading for characters that are currently not available (when policy allows).
260675 at main changed the timing of reading glyph data by moving it from tree construction over to layout.
This patch restores previous behavior -for details see webkit.org/b/252668.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/fallback-remote-to-data-url-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-display/font-display-failure-fallback-expected.txt:
* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebCore/rendering/RenderText.cpp: insertedIntoTree is also a candidate, but that my trigger redundant reading when detach/re-attach happens.
(WebCore::initiateFontLoadingByAccessingGlyphData):
(WebCore::RenderText::styleDidChange):

Canonical link: https://commits.webkit.org/262113@main