[webkit-changes] [WebKit/WebKit] 146943: Platform should support showing more descriptive l...

dewei-zhu noreply at github.com
Fri Mar 24 12:31:12 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 14694378eb0cc9e6f21841c5cd22ca976883adae
      https://github.com/WebKit/WebKit/commit/14694378eb0cc9e6f21841c5cd22ca976883adae
  Author: Dewei Zhu <dewei_zhu at apple.com>
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
    M Websites/perf.webkit.org/init-database.sql
    M Websites/perf.webkit.org/migrate-database.sql
    M Websites/perf.webkit.org/public/admin/platforms.php
    M Websites/perf.webkit.org/public/include/manifest-generator.php
    M Websites/perf.webkit.org/public/v3/components/chart-styles.js
    M Websites/perf.webkit.org/public/v3/components/custom-analysis-task-configurator.js
    M Websites/perf.webkit.org/public/v3/components/custom-configuration-test-group-form.js
    M Websites/perf.webkit.org/public/v3/models/platform.js
    M Websites/perf.webkit.org/public/v3/pages/chart-pane.js
    M Websites/perf.webkit.org/public/v3/pages/summary-page.js
    M Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js
    M Websites/perf.webkit.org/server-tests/api-manifest-tests.js

  Log Message:
  -----------
  Platform should support showing more descriptive label instead of name.
https://bugs.webkit.org/show_bug.cgi?id=254360
rdar://107119770

Reviewed by Alexey Proskuryakov.

Add label field to 'platform' table to have the ability to show more decriptive
content for the platform with more flexibility.

* Websites/perf.webkit.org/init-database.sql: Added 'platform_label' to 'platform' table.
* Websites/perf.webkit.org/migrate-database.sql: Added migration sql.
* Websites/perf.webkit.org/public/admin/platforms.php: Added support to edit platform.label in admin page.
* Websites/perf.webkit.org/public/include/manifest-generator.php: Expose platform.label to manifest.
* Websites/perf.webkit.org/public/v3/components/chart-styles.js:
(ChartStyles.resolveConfiguration): Use platform.label instead of platform.name.
* Websites/perf.webkit.org/public/v3/components/custom-analysis-task-configurator.js:
(CustomAnalysisTaskConfigurator.prototype._updateTriggerable):
* Websites/perf.webkit.org/public/v3/components/custom-configuration-test-group-form.js:
(CustomConfigurationTestGroupForm.prototype._updateTestGroupName): Use platform.label instead of platform.name.
* Websites/perf.webkit.org/public/v3/models/platform.js:
(Platform):
(Platform.prototype.label): Added label function to expose label information and fallback to platform name when
platform label is not specified.
* Websites/perf.webkit.org/public/v3/pages/chart-pane.js:
(ChartPane.prototype.render):
* Websites/perf.webkit.org/public/v3/pages/summary-page.js: Use platform.label instead of platform.name.
(SummaryPage.prototype._warningTextForGroup.mapAndSortByName):
* Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js: Use platform.label instead of platform.name.
(TestFreshnessPage.prototype._renderTooltip):
* Websites/perf.webkit.org/server-tests/api-manifest-tests.js: Updated unit tests.

Canonical link: https://commits.webkit.org/262091@main




More information about the webkit-changes mailing list