[webkit-changes] [WebKit/WebKit] 15f31b: Custom highlight creation behind marked text shoul...
Abrar Rahman Protyasha
noreply at github.com
Thu Mar 23 22:31:59 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 15f31bc80d50ced54c1f380aece3cfcb1c121504
https://github.com/WebKit/WebKit/commit/15f31bc80d50ced54c1f380aece3cfcb1c121504
Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
Date: 2023-03-23 (Thu, 23 Mar 2023)
Changed paths:
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
Log Message:
-----------
Custom highlight creation behind marked text should not be gated on input sources supporting live conversion only
https://bugs.webkit.org/show_bug.cgi?id=254354
rdar://107142115
Reviewed by Wenson Hsieh.
Previously, we gated custom highlight creation with a check on the
`NSMarkedClauseSegmentAttributeName` attribute. This allowed us to honor
background color only in the case of live conversion. Since that is
no longer the case, it is undesirable to gate our behavior to the live
conversion case.
As such, we remove this attribute check and allow custom highlight
creation for other IMEs.
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(compositionHighlights):
Canonical link: https://commits.webkit.org/262060@main
More information about the webkit-changes
mailing list