[webkit-changes] [WebKit/WebKit] 6e4c6e: Assertion failure in CompositeEditCommand::movePar...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6e4c6ef4ca8a761a76514b825a3f79e8bd63413d
      https://github.com/WebKit/WebKit/commit/6e4c6ef4ca8a761a76514b825a3f79e8bd63413d
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-03-23 (Thu, 23 Mar 2023)

  Changed paths:
    A LayoutTests/editing/execCommand/insert-list-move-paragraph-display-contents-crash-expected.txt
    A LayoutTests/editing/execCommand/insert-list-move-paragraph-display-contents-crash.html
    M Source/WebCore/editing/InsertListCommand.cpp

  Log Message:
  -----------
  Assertion failure in CompositeEditCommand::moveParagraph via InsertListCommand::listifyParagraph
https://bugs.webkit.org/show_bug.cgi?id=254375

Reviewed by Wenson Hsieh.

https://commits.webkit.org/70668@main made InsertListCommand::listifyParagraph to cross editing boundaries
to look for the start & the end of the current paragraph so that we can include non-editable inline content.
This, however, is inconsistent with CompositeEditCommand::moveParagraph's precondition that startOfParagraph
is the start of paragraph without crossing editing boundaries.

This patch addresses this precondition by calling startOfParagraph and endOfParagraph for the second time
without specifying CanSkipOverEditingBoundary.

* LayoutTests/editing/execCommand/insert-list-move-paragraph-display-contents-crash-expected.txt: Added.
* LayoutTests/editing/execCommand/insert-list-move-paragraph-display-contents-crash.html: Added.
* Source/WebCore/editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::listifyParagraph):

Canonical link: https://commits.webkit.org/262051@main