[webkit-changes] [WebKit/WebKit] db1751: Add Swift modulemap for WebKit Private APIs

Ian Anderson noreply at github.com
Thu Mar 23 13:51:32 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: db17513feb3f72a858f82a6bd062ba5127071795
      https://github.com/WebKit/WebKit/commit/db17513feb3f72a858f82a6bd062ba5127071795
  Author: Ian Anderson <iana at apple.com>
  Date:   2023-03-23 (Thu, 23 Mar 2023)

  Changed paths:
    M Source/WebKit/Configurations/Base.xcconfig
    M Source/WebKit/Configurations/WebKit.xcconfig
    M Source/WebKit/DerivedSources-input.xcfilelist
    M Source/WebKit/DerivedSources-output.xcfilelist
    M Source/WebKit/DerivedSources.make
    A Source/WebKit/Modules/OSX_Private.modulemap
    A Source/WebKit/Modules/iOS_Private.modulemap
    M Source/WebKit/Platform/cocoa/WKCrashReporter.h
    M Source/WebKit/Platform/unix/EnvironmentUtilities.h
    M Source/WebKit/Shared/Cocoa/XPCEndpoint.h
    M Source/WebKit/Shared/Cocoa/XPCEndpointClient.h
    M Source/WebKit/Shared/WebPushDaemonConstants.h
    M Source/WebKit/UIProcess/API/C/WKNotificationManager.h
    M Source/WebKit/UIProcess/API/C/WKWebsitePolicies.h
    M Source/WebKit/UIProcess/API/Cocoa/WKContextMenuElementInfoPrivate.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKInspectorPrivate.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKInspectorPrivateForTesting.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKRemoteWebInspectorViewControllerPrivate.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanelForTesting.h
    M Source/WebKit/UIProcess/API/cpp/WKRetainPtr.h
    M Source/WebKit/UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.h
    M Source/WebKit/UIProcess/ios/fullscreen/FullscreenTouchSecheuristicParameters.h
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  -----------
  Add Swift modulemap for WebKit Private APIs

https://bugs.webkit.org/show_bug.cgi?id=203059
rdar://37471861

Reviewed by Elliott Williams and Dean Jackson.

Add private module maps for WebKit. WebEventRegion.h is conditionally installed,
so the private module maps need to be unifdef'ed and manually copied rather than
using the normal Xcode mechanism.
DerivedSources.make isn't passing an SDK or -target to clang to figure out
FEATURE_AND_PLATFORM_DEFINES because they aren't defined yet, fix that by
defining those earlier.
Fix all of the private headers to compile in Objective-C, mostly by adding C++
guards.

* Source/WebKit/Configurations/Base.xcconfig:
* Source/WebKit/Configurations/WebKit.xcconfig:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources-output.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Modules/OSX_Private.modulemap: Added.
* Source/WebKit/Modules/iOS_Private.modulemap: Added.
* Source/WebKit/Platform/cocoa/WKCrashReporter.h:
* Source/WebKit/Platform/unix/EnvironmentUtilities.h:
* Source/WebKit/Shared/Cocoa/XPCEndpoint.h:
* Source/WebKit/Shared/Cocoa/XPCEndpointClient.h:
* Source/WebKit/Shared/WebPushDaemonConstants.h:
* Source/WebKit/UIProcess/API/C/WKNotificationManager.h:
* Source/WebKit/UIProcess/API/C/WKWebsitePolicies.h:
* Source/WebKit/UIProcess/API/Cocoa/WKContextMenuElementInfoPrivate.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKInspectorPrivate.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKInspectorPrivateForTesting.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKRemoteWebInspectorViewControllerPrivate.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanelForTesting.h:
* Source/WebKit/UIProcess/API/cpp/WKRetainPtr.h:
* Source/WebKit/UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.h:
* Source/WebKit/UIProcess/ios/fullscreen/FullscreenTouchSecheuristicParameters.h:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/262032@main




More information about the webkit-changes mailing list