[webkit-changes] [WebKit/WebKit] 8da564: [CMake] Replace WebKit_INCLUDE_DIRECTORIES with We...

Fujii Hironori noreply at github.com
Thu Mar 23 13:17:27 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8da56411057822ac3d05d721c8ceb8b1b6f9dd2a
      https://github.com/WebKit/WebKit/commit/8da56411057822ac3d05d721c8ceb8b1b6f9dd2a
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2023-03-23 (Thu, 23 Mar 2023)

  Changed paths:
    M Source/WebKit/CMakeLists.txt
    M Source/WebKit/PlatformGTK.cmake
    M Source/WebKit/PlatformGTKDeprecated.cmake
    M Source/WebKit/PlatformPlayStation.cmake
    M Source/WebKit/PlatformWPE.cmake
    M Source/WebKit/PlatformWin.cmake
    M Tools/MiniBrowser/gtk/CMakeLists.txt
    M Tools/TestWebKitAPI/PlatformGTK.cmake
    M Tools/TestWebKitAPI/glib/CMakeLists.txt
    M Tools/WebKitTestRunner/PlatformGTK.cmake
    M Tools/WebKitTestRunner/PlatformWPE.cmake

  Log Message:
  -----------
  [CMake] Replace WebKit_INCLUDE_DIRECTORIES with WebKit_PRIVATE_INCLUDE_DIRECTORIES to stop the propagation
https://bugs.webkit.org/show_bug.cgi?id=254216

Reviewed by Don Olmstead.

WebKit implementation include directories were unexpectedly propagated
to clients. We should use WebKit_PRIVATE_INCLUDE_DIRECTORIES instead
of WebKit_INCLUDE_DIRECTORIES to stop the propagation.

WebKitTestRunner and TestWebKitAPI of GTK and WPE are using internal
API headers and forwarding headers. They need some include paths.

* Source/WebKit/CMakeLists.txt:
* Source/WebKit/PlatformGTK.cmake:
* Source/WebKit/PlatformGTKDeprecated.cmake:
* Source/WebKit/PlatformPlayStation.cmake:
* Source/WebKit/PlatformWPE.cmake:
* Source/WebKit/PlatformWin.cmake:
* Tools/MiniBrowser/gtk/CMakeLists.txt:
* Tools/TestWebKitAPI/PlatformGTK.cmake:
* Tools/TestWebKitAPI/glib/CMakeLists.txt:
* Tools/WebKitTestRunner/PlatformGTK.cmake:
* Tools/WebKitTestRunner/PlatformWPE.cmake:

Canonical link: https://commits.webkit.org/262028@main




More information about the webkit-changes mailing list