[webkit-changes] [WebKit/WebKit] 35e844: REGRESSION (260842 at main): Rendered document marker...

Aditya Keerthi noreply at github.com
Thu Mar 23 10:25:06 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 35e844fd941fb841c8342d7e19f70bcd17d81869
      https://github.com/WebKit/WebKit/commit/35e844fd941fb841c8342d7e19f70bcd17d81869
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2023-03-23 (Thu, 23 Mar 2023)

  Changed paths:
    M Source/WebCore/rendering/TextBoxPainter.cpp

  Log Message:
  -----------
  REGRESSION (260842 at main): Rendered document markers are always opaque
https://bugs.webkit.org/show_bug.cgi?id=254314
rdar://106372237

Reviewed by Wenson Hsieh.

In order to support fading out document markers, 260842 at main added logic to
adjust the opacity of the used marker color at paint time. However, the method
used to adjust opacity overrides the alpha value of the color rather than
multiplying it. This results in opaque colors as the alpha value is forced to 1.

* Source/WebCore/rendering/TextBoxPainter.cpp:
(WebCore::TextBoxPainter<TextBoxPath>::paintPlatformDocumentMarker):

Canonical link: https://commits.webkit.org/262022@main




More information about the webkit-changes mailing list