[webkit-changes] [WebKit/WebKit] 39a383: [GPUP][MSE] networkState doesn't move to NETWORK_I...

Jean-Yves Avenard noreply at github.com
Thu Mar 23 08:24:02 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 39a3835b1f4151f2c7cf011e2f5df382b7a7e6b7
      https://github.com/WebKit/WebKit/commit/39a3835b1f4151f2c7cf011e2f5df382b7a7e6b7
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2023-03-23 (Thu, 23 Mar 2023)

  Changed paths:
    M LayoutTests/media/media-source/media-source-end-of-stream.html
    M Source/WebCore/platform/graphics/MediaSourcePrivate.h
    M Source/WebCore/platform/graphics/SourceBufferPrivate.cpp
    M Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.cpp
    M Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.h
    M Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.messages.in
    M Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.cpp
    M Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.h

  Log Message:
  -----------
  [GPUP][MSE] networkState doesn't move to NETWORK_IDLE once MediaSource.endOfStream() is called
https://bugs.webkit.org/show_bug.cgi?id=254324
rdar://107129124

Reviewed by Youenn Fablet.

The required methods weren't implemented in the
MediaSourcePrivateRemote/RemoteMediaSourceProxy combo of objects.
We implement them.

Covered in media/media-source/media-source-end-of-stream.html once
webkit.org/b/225367 is done.

* LayoutTests/media/media-source/media-source-end-of-stream.html: Fix whitespaces
* Source/WebCore/platform/graphics/MediaSourcePrivate.h:
* Source/WebCore/platform/graphics/SourceBufferPrivate.cpp:
(WebCore::SourceBufferPrivate::addTrackBuffer): Whitespaces fix
* Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.cpp:
(WebKit::RemoteMediaSourceProxy::markEndOfStream):
(WebKit::RemoteMediaSourceProxy::unmarkEndOfStream):
* Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.h:
* Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.messages.in:
* Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.cpp:
(WebKit::MediaSourcePrivateRemote::markEndOfStream):
(WebKit::MediaSourcePrivateRemote::unmarkEndOfStream):
(WebKit::MediaSourcePrivateRemote::isEnded const):
* Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.h:

Canonical link: https://commits.webkit.org/262016@main




More information about the webkit-changes mailing list