[webkit-changes] [WebKit/WebKit] 359587: (REGRESSION 261688 at main) Repaint issue when adding...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 359587ba5615020104960ff526a07ec217c3c80d
      https://github.com/WebKit/WebKit/commit/359587ba5615020104960ff526a07ec217c3c80d
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-03-22 (Wed, 22 Mar 2023)

  Changed paths:
    A LayoutTests/fast/repaint/content-change-in-out-of-flow-container-expected.txt
    A LayoutTests/fast/repaint/content-change-in-out-of-flow-container.html
    M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.cpp

  Log Message:
  -----------
  (REGRESSION 261688 at main) Repaint issue when adding text to a textbox
https://bugs.webkit.org/show_bug.cgi?id=254282
<rdar://107038111>

Reviewed by Antti Koivisto.

261688 at main moved some code from LineLayout over to InlineContentBuilder::build.
However an extra (incorrect) condition got added to the "repaint new content" part. When it is _not_ a partial layout (we simply replace old content)
we don't have a "first damaged line". Prior to 261688 at main we did fallback to 0 in case of no damage.

* LayoutTests/fast/repaint/content-change-in-out-of-flow-container-expected.txt: Added.
* LayoutTests/fast/repaint/content-change-in-out-of-flow-container.html: Added.
* Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.cpp:
(WebCore::LayoutIntegration::InlineContentBuilder::build const): (also move repaint after adjustDisplayLines() where we compute line inkOverflow)

Canonical link: https://commits.webkit.org/261989@main