[webkit-changes] [WebKit/WebKit] 192e26: New test: TestWebKitAPI.TextManipulation.StartText...

Ryosuke Niwa noreply at github.com
Wed Mar 22 13:11:42 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 192e26a16ad54baf1da70e6da769e4b38bbb0671
      https://github.com/WebKit/WebKit/commit/192e26a16ad54baf1da70e6da769e4b38bbb0671
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-03-22 (Wed, 22 Mar 2023)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm

  Log Message:
  -----------
  New test: TestWebKitAPI.TextManipulation.StartTextManipulationFindsContentInIframeInsertedLater is a flaky failure on iOS and Ventura
https://bugs.webkit.org/show_bug.cgi?id=254192

Reviewed by Wenson Hsieh.

The flakiness was caused by the race condition between when the 4th item is created after DOM mutation and when done is set to true.
Use srcdoc instead of setting innerHTML so that there is no DOM mutation, and therefore there will always be at most 3 items.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/261986@main




More information about the webkit-changes mailing list