[webkit-changes] [WebKit/WebKit] 57dd97: [git-webkit] Force pre-push hooks to be up-to-date

Jonathan Bedard noreply at github.com
Wed Mar 22 10:29:09 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 57dd97a2399f033b231b2e90246c7a916f1ff01c
      https://github.com/WebKit/WebKit/commit/57dd97a2399f033b231b2e90246c7a916f1ff01c
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2023-03-22 (Wed, 22 Mar 2023)

  Changed paths:
    M Tools/Scripts/libraries/webkitscmpy/setup.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/install_hooks.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/publish.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/install_hooks_unittest.py

  Log Message:
  -----------
  [git-webkit] Force pre-push hooks to be up-to-date
https://bugs.webkit.org/show_bug.cgi?id=253972
rdar://106760739

Reviewed by Aakash Jain and Ryan Haddad.

If a checkout defines a pre-push hook, prevent users from running commands
which invoke `git push` without first installing the hook.

* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/install_hooks.py:
(InstallHooks.version_for): Extract version from a hook template file.
(InstallHooks.hook_needs_update): Compare the checked in hook template to the installed
hook template.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py:
(Land.main): Exit program if our pre-push hook is out of date.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/publish.py:
(Publish.main): Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
(PullRequest.main): Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/install_hooks_unittest.py: Added.
(TestInstallHooks):

Canonical link: https://commits.webkit.org/261970@main




More information about the webkit-changes mailing list