[webkit-changes] [WebKit/WebKit] 645e98: [GTK] Slow scroll adjustment when using a mouse wheel

Carlos Garcia Campos noreply at github.com
Wed Mar 22 06:22:06 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 645e981e523ddb5f43d5b53a545d320ef0f38c25
      https://github.com/WebKit/WebKit/commit/645e981e523ddb5f43d5b53a545d320ef0f38c25
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2023-03-22 (Wed, 22 Mar 2023)

  Changed paths:
    M Source/WebCore/page/LocalFrameView.cpp
    M Source/WebCore/platform/ScrollView.cpp
    M Source/WebCore/platform/Scrollbar.cpp
    M Source/WebCore/platform/Scrollbar.h
    M Source/WebCore/rendering/RenderLayerScrollableArea.cpp
    M Source/WebCore/testing/Internals.cpp
    M Source/WebKit/Shared/NativeWebWheelEvent.h
    M Source/WebKit/Shared/gtk/NativeWebWheelEventGtk.cpp
    M Source/WebKit/Shared/gtk/WebEventFactory.cpp
    M Source/WebKit/Shared/gtk/WebEventFactory.h
    M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp

  Log Message:
  -----------
  [GTK] Slow scroll adjustment when using a mouse wheel
https://bugs.webkit.org/show_bug.cgi?id=168300

Reviewed by Michael Catanzaro.

Use a different scroll step depending on the scrollable area size,
matching what GTK4 does.

* Source/WebCore/page/FrameView.cpp:
(WebCore::FrameView::updateScrollbarSteps):
* Source/WebCore/platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbarSteps):
* Source/WebCore/platform/Scrollbar.cpp:
(WebCore::Scrollbar::pixelsPerLineStep):
* Source/WebCore/platform/Scrollbar.h:
* Source/WebCore/rendering/RenderLayerScrollableArea.cpp:
(WebCore::RenderLayerScrollableArea::updateScrollbarSteps):
* Source/WebKit/Shared/NativeWebWheelEvent.h:
* Source/WebKit/Shared/gtk/NativeWebWheelEventGtk.cpp:
* Source/WebKit/Shared/gtk/WebEventFactory.cpp:
(WebKit::WebEventFactory::createWebWheelEvent): Deleted.
* Source/WebKit/Shared/gtk/WebEventFactory.h:
* Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseScrollEvent):
(handleScroll):
(webkitWebViewBaseHandleWheelEvent): Deleted.

Canonical link: https://commits.webkit.org/261961@main




More information about the webkit-changes mailing list