[webkit-changes] [WebKit/WebKit] 20053b: [MSE] readyState should change back to HAVE_METADA...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 20053bdeedfdba913322e589de7b2f3f257be790
      https://github.com/WebKit/WebKit/commit/20053bdeedfdba913322e589de7b2f3f257be790
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2023-03-22 (Wed, 22 Mar 2023)

  Changed paths:
    M LayoutTests/media/media-source/media-source-monitor-playing-event.html
    A LayoutTests/media/media-source/media-source-remove-readystate-expected.txt
    A LayoutTests/media/media-source/media-source-remove-readystate.html
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/Modules/mediasource/SourceBuffer.cpp
    M Source/WebCore/platform/graphics/SourceBufferPrivate.cpp

  Log Message:
  -----------
  [MSE] readyState should change back to HAVE_METADATA when removing sample at current playtime
https://bugs.webkit.org/show_bug.cgi?id=254198
rdar://106979551

Reviewed by Youenn Fablet.

Ensure that we only run the removeCodedFrames's completionHandler after
we've updated the readyState in the content process.

Fly-by fix: We must ensure that the SourceBuffer hasn't been deleted by
time the removeCodedFrames operation completes.

* LayoutTests/media/media-source/media-source-remove-readystate-expected.txt: Added.
* LayoutTests/media/media-source/media-source-remove-readystate.html: Added.
* LayoutTests/media/media-source/media-source-monitor-playing-event.html: remove sleep(1s) as it is no longer required.
* LayoutTests/platform/glib/TestExpectations: Mark test as failine, GStreamer doesn't handle readyState as it should.
* Source/WebCore/platform/graphics/SourceBufferPrivate.cpp:
(WebCore::SourceBufferPrivate::removeCodedFrames):
* Source/WebCore/Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::removeTimerFired):

Canonical link: https://commits.webkit.org/261955@main