[webkit-changes] [WebKit/WebKit] aff28b: [Gstreamer][WebRTC] webrtc/video-disabled-black.ht...

Philippe Normand noreply at github.com
Wed Mar 22 02:10:41 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aff28bc50d0e283250350647403aba6131fbd8fb
      https://github.com/WebKit/WebKit/commit/aff28bc50d0e283250350647403aba6131fbd8fb
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-03-22 (Wed, 22 Mar 2023)

  Changed paths:
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/webrtc/routines.js
    M LayoutTests/webrtc/video-disabled-black.html
    M Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp

  Log Message:
  -----------
  [Gstreamer][WebRTC] webrtc/video-disabled-black.html fails
https://bugs.webkit.org/show_bug.cgi?id=254212

Reviewed by Xabier Rodriguez-Calvar.

Flushing a disabled video track would lead to a caps negotiation failure afterwards, so flush only
if the track is being re-enabled.

The webrtc/video-disabled-black.html test was also rewritten in order to avoid flakiness, we now
check the video at most 200 times instead of one, before failing the test.

Also drive-by in MediaStreamSource, rebuild black frame caps when needed, instead of attempting to
update caps that are not writable.

* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/webrtc/routines.js:
* LayoutTests/webrtc/video-disabled-black.html:
* Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:

Canonical link: https://commits.webkit.org/261951@main




More information about the webkit-changes mailing list