[webkit-changes] [WebKit/WebKit] 29a107: Re-enable new Set methods following confirmation o...

Ross Kirsling noreply at github.com
Wed Mar 22 00:28:18 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 29a10740cf9d9d7653a729b9767480a3146cabcf
      https://github.com/WebKit/WebKit/commit/29a10740cf9d9d7653a729b9767480a3146cabcf
  Author: Ross Kirsling <ross.kirsling at sony.com>
  Date:   2023-03-22 (Wed, 22 Mar 2023)

  Changed paths:
    M JSTests/stress/set-prototype-intersection.js
    M LayoutTests/js/Object-getOwnPropertyNames-expected.txt
    M LayoutTests/js/script-tests/Object-getOwnPropertyNames.js
    M Source/JavaScriptCore/builtins/SetPrototype.js
    M Source/JavaScriptCore/runtime/OptionsList.h

  Log Message:
  -----------
  Re-enable new Set methods following confirmation of intersection algorithm
https://bugs.webkit.org/show_bug.cgi?id=254249

Reviewed by Yusuke Suzuki.

The TC39 Set Methods proposal had been blocked pending a final decision on the algorithm for Set.prototype.intersection,
but it was decided in today's plenary to simply not sort the output in the case where we iterate over the parameter set.

This is our existing behavior, so https://webkit.org/b/251869 becomes unnecessary and we can just go with what we have.

* JSTests/stress/set-prototype-intersection.js:
Add a couple of tests to demonstrate commutativity.

* LayoutTests/js/Object-getOwnPropertyNames-expected.txt:
* LayoutTests/js/script-tests/Object-getOwnPropertyNames.js:
Update expectations.

* Source/JavaScriptCore/builtins/SetPrototype.js:
* Source/JavaScriptCore/runtime/OptionsList.h:
Remove FIXMEs and flip runtime option.

Canonical link: https://commits.webkit.org/261946@main




More information about the webkit-changes mailing list